I have used int32_t for llama_memory_seq_div#25892
Open
dogukandemirci-software-engineer wants to merge 1 commit into
Open
I have used int32_t for llama_memory_seq_div#25892dogukandemirci-software-engineer wants to merge 1 commit into
dogukandemirci-software-engineer wants to merge 1 commit into
Conversation
…hile sibling params (p0, p1) are llama_pos (int32_t). Use int32_t for consistency with rest of the public API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have researched the llama.h and find a memory sequence divisorfunction to change type to guideline as guided in #4574 (for fixed width integer standart)
BEFORE
"""
LLAMA_API void llama_memory_seq_div(
llama_memory_t mem,
llama_seq_id seq_id,
llama_pos p0,
llama_pos p1,
int d);
"""
AFTER
"""
LLAMA_API void llama_memory_seq_div(
llama_memory_t mem,
llama_seq_id seq_id,
llama_pos p0,
llama_pos p1,
int32_t d);
"""
Closes #4574