OpenCL: Disable unsupported allocation of Adreno large buffers to fix compilation failure in OpenCL 2.x#25897
Closed
mgroeber9110 wants to merge 1 commit into
Closed
Conversation
…fferWithProperties API is not available
github-actions
Bot
added
ggml
Contributor
|
I think this has already been fixed. Can you try again with the latest master? |
Contributor
Author
|
I don't have my dev machine with me this week, but I see now that 12127de indeed fixed this already a few days ago. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This change disables the Adreno large buffer fallback when targeting OpenCL 2.x and older. This is necessary because the
clCreateBufferWithPropertiesAPI is not available in OpenCL earlier than 3.0.Additional information
This restores the ability to compile with
GGML_OPENCL_TARGET_VERSIONset to 210 or less, which failed because of undefined symbols before. I do not expect this to negatively affect Adreno support, because this was only usable with OpenCL 3.0 so far anyway. As this is the only failure currently preventing OpenCL 2.x compilation, I believe this is still worth fixing (even if few people are using this variant).Requirements