build : add ROCm component directories to ggml-hip RPATH#25899
Open
liminfei-amd wants to merge 1 commit into
Open
build : add ROCm component directories to ggml-hip RPATH#25899liminfei-amd wants to merge 1 commit into
liminfei-amd wants to merge 1 commit into
Conversation
libggml-hip directly depends on rocBLAS, hipBLAS, and the HIP runtime. Add their imported target directories to its build and install RPATH so versioned ROCm layouts load without a ROCm LD_LIBRARY_PATH. Fixes ggml-org#25807 Reported-by: IIIIIllllIIIIIlllll
github-actions
Bot
added
the
ggml
Collaborator
|
I find it bad and very likely a bug that rocm libraries are not in the system's ld search path in an rocm image, this approach also dosent help at all when the binary is built on one machine and then distributed to others. Please confirm that rocm libaries NOT being in ld's search path in rocm docker images is intentional. |
Contributor
Author
Thank you for your suggestion. We are currently investigating whether this can be fixed from theRock. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
libggml-hip.sodirectly needs all three, but its own RUNPATH does not contain their directories; an executable'sDT_RUNPATHis not recursively inherited for those dependencies.roc::rocblas,roc::hipblas, andhip::amdhip64target directories toggml-hipBUILD_RPATHandINSTALL_RPATH.Fixes #25807.
Validation
571d0d5in the official ROCm 7.14 image, the baseline builds but clean launch exits 127 onlibhipblas.so.3; supplying the component path succeeds.LD_LIBRARY_PATH.