Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/validate.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:

env:
kubeconform_ver: "0.4.13"
dyff_ver: "1.5.4"
dyff_ver: "1.7.1"
clusterctl_ver: "1.2.0"
apptestctl_ver: "0.18.0"
kind_ver: "0.12.0"
Expand Down
12 changes: 12 additions & 0 deletions .github/workflows/yaml-diff.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
name: yaml-diff

on:
pull_request:

permissions:
contents: read
pull-requests: write

jobs:
yaml-diff:
uses: giantswarm/github-workflows/.github/workflows/yaml-diff.yaml@main
13 changes: 13 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,21 @@ following [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Unreleased

### Added

- Semantic YAML diff PR comments via the new `yaml-diff` workflow
(calls `giantswarm/github-workflows/.github/workflows/yaml-diff.yaml`).
Key reordering without value changes no longer shows up as noise in PR
reviews. Alphabetical key-ordering enforcement in `.yamllint` is
unchanged in this release; it will be dropped in a follow-up once the
bot has run on real PRs.
See [giantswarm/roadmap#4121](https://github.com/giantswarm/roadmap/issues/4121).

### Changed

- Bump `dyff_ver` from `1.5.4` to `1.7.1` in the existing rendered-manifest
diff job (`validate.yaml`), to standardize on the version used by the new
`yaml-diff` workflow.
- migrated `.spec.config` to `.spec.extraConfigs`
- Templates: Rename `nginx-ingress-controller` to `ingress-nginx`. ([#85](https://github.com/giantswarm/gitops-template/pull/85))

Expand Down
Loading