Implementing a selections and other things#2
Open
gibiansky wants to merge 8 commits intogilligan:masterfrom
Open
Implementing a selections and other things#2gibiansky wants to merge 8 commits intogilligan:masterfrom
a selections and other things#2gibiansky wants to merge 8 commits intogilligan:masterfrom
Conversation
Owner
|
There seem to be some issues still: -- this is a comment
foobar [] = 42
foobar (x:xs) = x
-- this is a comment
foobar :: IO ()
foobar = do
let x = "test1"
let y = "test2"
putStrLn x
putStrLn y
Can you have a look at those issues ? |
Author
|
Yup, I'll take a look. Although for (1), that is purposeful – I definitely think selecting comments should be possible. There are times when I wish to reformat those! (Such as keeping them within 80 or 100 characters.) |
Owner
|
Adding preliminary support for this was rather quick, did it in the select-a branch. It does need some cleaning up though. Still interested to see a fixed version of your fork though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pretty big change (almost a rewrite), so no pressure to merge it. Feel free to test it and find edge cases where it doesn't work, in which case I can fix them. (If you use Vundle, you can just use
Plugin 'gibiansky/vim-textobj-haskell'to do so.)