[codex] Fix local daemon auto-connect for test-support wrappers#924
Draft
[codex] Fix local daemon auto-connect for test-support wrappers#924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test-supportwrappers to auto-connect to the daemon when they are not running under the integration harnessRoot Cause
init_daemon_telemetry_handle()treated everytest-supportbuild as a harness-managed test binary. In local dev, that meant the wrapper skipped daemon auto-connect unlessGIT_AI_DAEMON_CONTROL_SOCKETwas set, leaving the telemetry handle disconnected and producing noisyfailed to send pre/post-statemessages even though the daemon fallback path still worked.Validation
cargo test test_harness_detection_uses_test_db_override_vars -- --nocapturecargo test --lib explicit_control_socket_override_wins_over_test_harness_marker -- --nocapturecargo build --bin git-ai --features test-supportexec -a git target/debug/git-ai add a.txtin a temp repo without daemon socket env vars; wrapper warning no longer appears