Add output GitHub #184
Open
Add output GitHub #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
インデントがおかしいようです。 |
|
今回の実装に関するテストコードがないので追加してください。 |
dfpro073
reviewed
Apr 12, 2025
lib/fizzbuzz.rb
Outdated
| 'fizz' | ||
| elsif number % 5 == 0 | ||
| 'buzz' | ||
| elsif number.to_s.include? '7' |
Author
|
@dfpro073 さんレビューありがとうございます！ 仕様の質問があります。 |
|
なるほど。そう言ったケースについて触れていませんでした。 ・３の倍数や５の倍数でも、７という数字がつく時はGitHubを表示 |
Author
|
テストコードを追加して、実装が終了しました。 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
・７という数字がつくときはGitHubを表示
を実装しました。レビューお願いします。