Skip to content

fix: store new_contributor parameter in __init__ #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zkoppert wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: store new_contributor parameter in __init__ #407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion contributor_stats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ def __init__(
sponsor_info: str,
):
"""Initialize the contributor_stats object"""
new_contributor = False
self.username = username
self.new_contributor = new_contributor
Comment on lines 48 to 49
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description says new_contributor “defaults to False”, but ContributorStats.__init__ currently requires the argument (no default value in the signature). Either update the PR description to match the code, or consider giving new_contributor a default of False if that’s the intended API.

Copilot uses AI. Check for mistakes.
self.avatar_url = avatar_url
Comment on lines 48 to 50
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behavior change (preserving the new_contributor constructor argument) is not covered by tests: there are no unit tests that instantiate ContributorStats with new_contributor=True and assert the instance retains it. Adding a focused regression test would prevent this from silently breaking again.

Copilot generated this review using guidance from repository custom instructions.
Expand Down
Loading