Allow loading schema from SDL definition file as well as JSON#60
Merged
rmosolgo merged 2 commits intogithub-community-projects:masterfrom Dec 6, 2025
Conversation
|
Is there anything that can be done to help move this PR along? 🙏 This is something our team would benefit from as we have introspection disabled for our graphql server. |
Contributor
Author
Knowing it would be helpful for someone else is a pretty good incentive to make time to finish it :) |
If passing a path to a file with a name that ends in ".graphql" or ".graphqls" (matching the filenames used in [graphql-ruby](https://github.com/rmosolgo/graphql-ruby/blob/master/lib/graphql/schema.rb#L116)), attempt to load the schema from that file assuming it's a schema definition rather than a JSON schema.
c9755e5 to
e474f12
Compare
rmosolgo
approved these changes
Dec 6, 2025
Collaborator
|
Weird about CI not running... I pulled the branch locally and confirmed that the new tests passed. (I did have one unrelated failure: I think it's because the backtrace format changed in my version of Ruby.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If passing a path to a file with a name that ends in ".graphql" or ".graphqls" (matching the filenames used in
graphql-ruby), attempt to load the schema from that file assuming it's a schema definition rather than a JSON schema.