Bump RuboCop and fix deprecation warnings#66
Merged
jmeridth merged 4 commits intogithub-community-projects:masterfrom May 28, 2025
Merged
Bump RuboCop and fix deprecation warnings#66jmeridth merged 4 commits intogithub-community-projects:masterfrom
jmeridth merged 4 commits intogithub-community-projects:masterfrom
Conversation
Contributor
issyl0
commented
Apr 6, 2025
issyl0
commented
- Bumps RuboCop and fix deprecations so we stop getting warnings from this gem in projects that use a greater RuboCop version.
- Supersedes chore(deps): update rubocop requirement from ~> 1.73.2 ~> 1.75.8 #64.
- This was showing a deprecation warning with the latest RuboCop version. ``` warning: Inheriting from `RuboCop::Cop::Cop` is deprecated. Use `RuboCop::Cop::Base` instead. For more information, see https://docs.rubocop.org/rubocop/v1_upgrade_notes.html ``
``` Scanning /Users/issyl0/repos/github/graphql-client/test/test_client.rb An error occurred while GraphQL/Heredoc cop was inspecting /Users/issyl0/repos/github/graphql-client/test/test_client.rb:724:19. unknown keyword: :location /Users/issyl0/.rbenv/versions/3.3.2/lib/ruby/gems/3.3.0/gems/rubocop-1.73.2/lib/rubocop/cop/base.rb:201:in `add_offense' /Users/issyl0/repos/github/graphql-client/lib/rubocop/cop/graphql/heredoc.rb:22:in `block in check_str' ```
AlenaSviridenko
approved these changes
Apr 8, 2025
AlenaSviridenko
left a comment
AlenaSviridenko
left a comment
There was a problem hiding this comment.
👋
Thanks for reaching out!
To be honest, I am far from expert in this project, but the update does seem fine, so let's try :)
jmeridth
approved these changes
May 28, 2025
Contributor
jmeridth
left a comment
jmeridth
left a comment
There was a problem hiding this comment.
These changes make sense. Going to approve and merge ignoring current test failures. We can address the current test failures after.
jmeridth
merged commit fa6df6f
into
github-community-projects:master
1 of 81 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.