Fix TypeScript with node shebang detected as JavaScript

[mondeja]

Fixes #7348

Description

TypeScript files with .ts extension which include "#!/usr/bin/env node or "#!/usr/bin/env node shebangs are misclassified as JavaScript files.

Checklist:

• I am adding a new extension to a language.

  • The new extension is used in hundreds of repositories on GitHub.com
    • Search results for each extension:
      • https://github.com/search?q=NOT+is%3Afork+path%3A*.ts+%22%23%21%2Fusr%2Fbin%2Fenv+node%22&type=code
  • I have included a real-world usage sample for all extensions added in this PR:
    • Sample source(s):
      • https://github.com/getsentry/sentry-wizard/blob/f252474d01cde0239c7682d91c4771349d4c5fe9/bin.ts
    • Sample license(s):
      • https://github.com/getsentry/sentry-wizard/blob/f252474d01cde0239c7682d91c4771349d4c5fe9/LICENSE
  • I have included a change to the heuristics to distinguish my language from others using the same extension.

• I am adding a new language.

  • The extension of the new language is used in hundreds of repositories on GitHub.com.
    • Search results for each extension:
      • https://github.com/search?type=code&q=NOT+is%3Afork+path%3A*.FOOBAR+KEYWORDS
  • I have included a real-world usage sample for all extensions added in this PR:
    • Sample source(s):
      • [URL to each sample source, if applicable]
    • Sample license(s):
  • I have included a syntax highlighting grammar: [URL to grammar repo]
  • I have added a color
    • Hex value: #RRGGBB
    • Rationale:
  • I have updated the heuristics to distinguish my language from others using the same extension.

• I am fixing a misclassified language

  • I have included a new sample for the misclassified language:
    • Sample source(s):
    • Sample license(s):
  • I have included a change to the heuristics to distinguish my language from others using the same extension.

• I am changing the source of a syntax highlighting grammar

  • Old: [URL to grammar repo]
  • New: [URL to grammar repo]

• I am updating a grammar submodule

• I am adding new or changing current functionality

  • I have added or updated the tests for the new or changed functionality.

• I am changing the color associated with a language

  • I have obtained agreement from the wider language community on this color change.
    • [URL to public discussion]
    • [Optional: URL to official branding guidelines for the language]

[lildude]

Please update the PR body to use the "I am adding a new extension to a language." part of the template and fill it in as if you're adding an extension.

The important part is we need real-world samples with their original filenames, and a link to the original source location and the license for legal reasons.

Please also update the test_find_by_interpreter test like in #7878 (the test wing pass until that PR is merged).

[Alhadis]

Since TypeScript is a clean superset of JavaScript, how will you identify a Node executable that ends in .ts but is syntactically valid JavaScript and TypeScript? Does Node.js actually support native runtime execution of TypeScript the way Deno does?

This is a can-of-worms we've dealt with before at Linguist…

[mondeja]

Since TypeScript is a clean superset of JavaScript, how will you identify a Node executable that ends in .ts but is syntactically valid JavaScript and TypeScript? Does Node.js actually support native runtime execution of TypeScript the way Deno does?

This is a can-of-worms we've dealt with before at Linguist…

You can differentiate them by the extension of the file. If it's JavasScript you can put a .js extension to the file, but if the file becomes TypeScript you can rename to use a .ts extension.

[Alhadis]

@mondeja And what about Node.js executables that don't have any file extensions?

[mondeja]

@mondeja And what about Node.js executables that don't have any file extensions?

For a file without an extension containing the #!/usr/bin/env node shebang, the result would be ambiguous (JavaScript + TypeScript), and subsequent strategies (heuristics, classifier) ​​would have to resolve it. Since TypeScript is a superset of JavaScript, a file without type annotations would likely be classified as JavaScript.

[Alhadis]

… and subsequent strategies (heuristics, classifier) ​​would have to resolve it.

This is the very issue that's plagued Linguist's past attempts at getting Node.js executables containing TypeScript to be recognised as the latter. Both JavaScript and TypeScript's syntaxes are very similar, and heuristics that match dead-giveaways (like declare type foo =) aren't going to match every ambiguous file, so the most common outcome is a repository that's partially classified as TypeScript, and partially classified as JavaScript. Usually incorrectly.

Also, does node even support running TypeScript executables?

[mondeja]

Also, does node even support running TypeScript executables?

Yes. Starting with Node.js 23.6 ts files can be executed running node file.ts.

This is the very issue that's plagued Linguist's past attempts at getting Node.js executables containing TypeScript to be recognised as the latter. Both JavaScript and TypeScript's syntaxes are very similar, and heuristics that match dead-giveaways (like declare type foo =) aren't going to match every ambiguous file, so the most common outcome is a repository that's partially classified as TypeScript, and partially classified as JavaScript. Usually incorrectly.

If there are bugs in linguist's classification logic we can fix them, of course. But that is out of the scope of this PR.