Promote OverlayAnalysisResourceChecksV2

[mbg]

This feature has been rolled out to 100% and therefore the default behaviour for some time.

This change is also in #4080, but this PR teases it out into an independent change with the correct justification. I.e. the Feature and corresponding checks are no longer required since they are already the default. This is independent of forthcoming changes, which are not required to remove these checks.

Risk assessment

For internal use only. Please select the risk level of this change:

• Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Workflow types:

• Advanced setup - Impacts users who have custom CodeQL workflows.
• Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...).

Products:

• Code Scanning - The changes impact analyses when analysis-kinds: code-scanning.
• Code Quality - The changes impact analyses when analysis-kinds: code-quality.
• Other first-party - The changes impact other first-party analyses.

Environments:

• Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency.
• GHES - Impacts CodeQL workflows on GitHub Enterprise Server.

How did/will you validate this change?

• Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).
• End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

• Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

• Telemetry - I rely on existing telemetry or have made changes to the telemetry.
  • Dashboards - I will watch relevant dashboards for issues after the release. Consider whether this requires this change to be released at a particular time rather than as part of a regular release.
  • Alerts - New or existing monitors will trip if something goes wrong with this change.

Are there any special considerations for merging or releasing this change?

• No special considerations - This change can be merged at any time.

Merge / deployment checklist

• Confirm this change is backwards compatible with existing workflows.
• Consider adding a changelog entry for this change.
• Confirm the readme and docs have been updated if necessary.

[Copilot]

Warning

• Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.

Pull request overview

Promotes the fully rolled-out overlay resource checks, making 14 GB the unconditional disk-space minimum.

Changes:

• Removes the obsolete V2 feature flag.
• Simplifies disk-space checks around the 14 GB minimum.
• Updates associated tests.

Show a summary per file

File	Description
src/feature-flags.ts	Removes the obsolete feature configuration.
src/config-utils.ts	Makes the 14 GB threshold unconditional.
src/config-utils.test.ts	Updates disk-space test scenarios.
lib/entry-points.js	Excluded from review by policy.

Review details

Tip

Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Files excluded by content exclusion policy (1)

• lib/entry-points.js

• Files reviewed: 3/4 changed files
• Comments generated: 1
• Review effort level: Balanced

[mario-campos]

Small and succint - LGTM