Go: Fix compilation of DataFlowImplConsistency.qll#20053
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a compilation error in the DataFlowImplConsistency.qll file by adding a module alias to resolve naming conflicts. The fix addresses the issue reported in GitHub issue #19890 where the file failed to compile due to ambiguous references to GoDataFlow.
- Adds an alias
Implfor theDataFlowImplSpecificimport to disambiguate references - Updates references to
GoDataFlowto use the qualified nameImpl::GoDataFlow
jketema
approved these changes
Jul 16, 2025
Contributor
jketema
left a comment
jketema
left a comment
There was a problem hiding this comment.
LGTM. Not sure how much weight my review carries 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out in #19890, this file didn't compile.