Skip to content

fix: improve demo recording pipeline and regenerate GIFs#9

Merged
DanWahlin merged 1 commit intomainfrom
fix/demo-recording-pipeline
Mar 7, 2026
Merged

fix: improve demo recording pipeline and regenerate GIFs#9
DanWahlin merged 1 commit intomainfrom
fix/demo-recording-pipeline

Conversation

@DanWahlin
Copy link
Collaborator

Summary

  • TUI scrolling fix: Added periodic hidden nudges (space+backspace every 3s) in tape files to keep the copilot TUI scrolled to the input area during streaming responses
  • VHS compatibility: Fixed multi-line prompt splitting and added missing framerate setting that was causing parse errors
  • Timing tuning: Bumped responseWait values across demos so recordings complete before cutoff (default 40s, per-demo up to 120s)
  • Pipeline cleanup: Removed scan:demos from pipeline to preserve curated config, removed unreliable full-review-demo (9 prompts, ~10min), added preview-gifs.js for quick visual validation
  • Regenerated all 17 demo GIFs with improved settings

Test plan

  • Spot-check GIFs in each chapter to verify demos show complete responses with input area visible
  • Run node .github/scripts/preview-gifs.js to extract preview frames and visually verify
  • Run npm run create:tapes to verify tape generation still works
  • Confirm no sample project files were modified

🤖 Generated with Claude Code

- Add periodic hidden nudges in tape files to keep copilot TUI scrolled
  to the input area during streaming responses
- Add multi-line prompt splitting for VHS Type command compatibility
- Tune responseWait values so demos complete before recording ends
- Add framerate setting to demos.json (was causing VHS parse errors)
- Remove full-review-demo (too complex to reliably reproduce)
- Remove scan:demos from generate:demos pipeline to preserve curated config
- Add preview-gifs.js utility for quick visual validation of recordings
- Regenerate all 17 demo GIFs with improved settings

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings March 7, 2026 05:34
@DanWahlin DanWahlin merged commit 9790def into main Mar 7, 2026
3 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the demo recording pipeline for a GitHub Copilot CLI course by addressing TUI scrolling issues in VHS tape recordings, fixing multi-line prompt handling, tuning response wait times, removing an unreliable long-running demo, and adding a utility for quick visual validation of generated GIFs.

Changes:

  • Replaced single Sleep wait blocks in tape files with periodic hidden space+backspace nudges (every 3s) to keep the copilot TUI scrolled to the input area during streaming responses, and bumped responseWait values so recordings complete fully
  • Removed the full-review-demo (9 prompts, ~10min) from demos.json and cleaned up its tape file, GIF, and README reference; also removed scan:demos from the generate:demos pipeline
  • Added preview-gifs.js utility for extracting preview frames from GIFs, fixed multi-line prompt splitting in create-tapes.js, and added missing framerate setting to scan-demos.js

Reviewed changes

Copilot reviewed 24 out of 43 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/scripts/create-tapes.js Added nudge generation logic, multi-line prompt splitting, and final nudge before exit
.github/scripts/demos.json Bumped default responseWait to 40, per-demo waits up to 120, removed full-review-demo
.github/scripts/scan-demos.js Added framerate: 15 to default settings
.github/scripts/preview-gifs.js New utility to extract preview frames from demo GIFs
package.json Removed scan:demos from generate:demos pipeline
07-putting-it-together/README.md Removed full-review-demo details/GIF reference
07-putting-it-together/images/full-review-demo.tape Deleted
07-putting-it-together/images/full-review-demo.gif Deleted
.gitignore Added demo-previews directory
**/images/*.tape (16 files) Regenerated with nudge pattern and updated wait times

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +30 to 33
framerate: 15,
startupWait: 5,
responseWait: 25,
exitWait: 2
Copy link

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The framerate: 15 default added here diverges from the framerate: 10 used in demos.json (line 8). Similarly, responseWait: 25 and exitWait: 2 here don't match the updated demos.json values of responseWait: 40 and exitWait: 3. While scan:demos was removed from the generate:demos pipeline, it's still available as a standalone script (npm run scan:demos). Running it would overwrite demos.json with these stale defaults, undoing the curated settings. Consider updating the defaults here to match demos.json, or adding a comment noting these are intentionally different.

Suggested change
framerate: 15,
startupWait: 5,
responseWait: 25,
exitWait: 2
framerate: 10,
startupWait: 5,
responseWait: 40,
exitWait: 3

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants