Skip to content

Use z-prefixed Go generated files#1268

Merged
stephentoub merged 1 commit into
github:mainfrom
qmuntal:go-z-generated-files
May 12, 2026
Merged

Use z-prefixed Go generated files#1268
stephentoub merged 1 commit into
github:mainfrom
qmuntal:go-z-generated-files

Conversation

@qmuntal
Copy link
Copy Markdown
Contributor

@qmuntal qmuntal commented May 12, 2026

Summary

  • rename Go codegen outputs to idiomatic z-prefixed filenames
  • update Go generated-file headers to use the Go standard Code generated ... DO NOT EDIT marker
  • update generated-file attributes and RPC API shape test path

Tests

  • go test . ./rpc

@qmuntal qmuntal requested a review from a team as a code owner May 12, 2026 15:17
Copilot AI review requested due to automatic review settings May 12, 2026 15:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Go SDK’s codegen outputs to use z-prefixed filenames (to control file ordering) and switches generated-file headers to Go’s standard // Code generated … DO NOT EDIT. marker, while updating repo metadata/tests that reference the generated files.

Changes:

  • Updated Go codegen (scripts/codegen/go.ts) to emit the standard Go generated-file header and write z*-prefixed output filenames.
  • Renamed/updated generated Go outputs and their headers (go/zsession_*.go, go/rpc/zrpc*.go).
  • Updated Go RPC API shape test and .gitattributes to reference/mark the new generated filenames.
Show a summary per file
File Description
scripts/codegen/go.ts Adds a reusable Go “DO NOT EDIT” header helper and updates output paths to z*-prefixed filenames.
go/zsession_events.go Updates generated header to the standard Go “Code generated … DO NOT EDIT.” marker.
go/zsession_encoding.go Updates generated header to the standard Go “Code generated … DO NOT EDIT.” marker.
go/rpc/zrpc.go Updates generated header to the standard Go “Code generated … DO NOT EDIT.” marker.
go/rpc/zrpc_encoding.go Updates generated header to the standard Go “Code generated … DO NOT EDIT.” marker.
go/rpc/generated_rpc_api_shape_test.go Updates parsing/error messages to reference zrpc.go.
.gitattributes Updates generated-file attributes to track the new z* Go generated filenames.

Copilot's findings

Files not reviewed (2)
  • go/rpc/zrpc_encoding.go: Language not supported
  • go/zsession_encoding.go: Language not supported
  • Files reviewed: 5/7 changed files
  • Comments generated: 0

@stephentoub stephentoub added this pull request to the merge queue May 12, 2026
Merged via the queue into github:main with commit e0a0f5e May 12, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants