Use z-prefixed Go generated files#1268
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Go SDK’s codegen outputs to use z-prefixed filenames (to control file ordering) and switches generated-file headers to Go’s standard // Code generated … DO NOT EDIT. marker, while updating repo metadata/tests that reference the generated files.
Changes:
- Updated Go codegen (
scripts/codegen/go.ts) to emit the standard Go generated-file header and writez*-prefixed output filenames. - Renamed/updated generated Go outputs and their headers (
go/zsession_*.go,go/rpc/zrpc*.go). - Updated Go RPC API shape test and
.gitattributesto reference/mark the new generated filenames.
Show a summary per file
| File | Description |
|---|---|
| scripts/codegen/go.ts | Adds a reusable Go “DO NOT EDIT” header helper and updates output paths to z*-prefixed filenames. |
| go/zsession_events.go | Updates generated header to the standard Go “Code generated … DO NOT EDIT.” marker. |
| go/zsession_encoding.go | Updates generated header to the standard Go “Code generated … DO NOT EDIT.” marker. |
| go/rpc/zrpc.go | Updates generated header to the standard Go “Code generated … DO NOT EDIT.” marker. |
| go/rpc/zrpc_encoding.go | Updates generated header to the standard Go “Code generated … DO NOT EDIT.” marker. |
| go/rpc/generated_rpc_api_shape_test.go | Updates parsing/error messages to reference zrpc.go. |
| .gitattributes | Updates generated-file attributes to track the new z* Go generated filenames. |
Copilot's findings
Files not reviewed (2)
- go/rpc/zrpc_encoding.go: Language not supported
- go/zsession_encoding.go: Language not supported
- Files reviewed: 5/7 changed files
- Comments generated: 0
stephentoub
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests