Fix Python codegen synthetic permission approval names - #1652
Merged
SteveSandersonMS merged 4 commits intoJul 31, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates the Python codegen post-processing to remove unused “synthetic” Quicktype-emitted @dataclass classes so they no longer appear in the generated module exports.
Changes:
- Added a post-processing pass to delete unreferenced synthetic
@dataclassblocks from generated Python. - Wired the new pass into the Python codegen pipeline using the schema’s known definition names.
- Added a Python regression test and updated the generated
rpc.pyoutput accordingly.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| scripts/codegen/python.ts | Adds removeUnusedSyntheticPythonDataclasses() and applies it during final Python code post-processing. |
| python/test_codegen_type_names.py | Adds a regression test asserting a known synthetic type is not exported while real types remain exported. |
| python/copilot/generated/rpc.py | Regenerated output removing the unused synthetic dataclass and its __all__ export entry. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
SteveSandersonMS
force-pushed
the
fix-python-codegen-long-type-names
branch
from
July 31, 2026 14:57
5755075 to
4aa1f83
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Review details
Suppressed comments (1)
python/test_codegen_type_names.py:13
- This only proves that at least one matching export exists. The loader test below can still pass when either schema-named alias is missing from
__all__, because it calls separate_load_*functions and never accesses the aliases themselves. Assert both exact session and location alias names here so the regression test covers the stated public exports.
assert approval_exports
- Files reviewed: 2/3 changed files
- Comments generated: 0 new
- Review effort level: Balanced
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
SteveSandersonMS
approved these changes
Jul 31, 2026
SteveSandersonMS
left a comment
SteveSandersonMS
left a comment
Contributor
There was a problem hiding this comment.
Thanks @abhinavgautam01!
|
edburns
pushed a commit
that referenced
this pull request
Aug 4, 2026
* Fix Python codegen synthetic permission approval names * Address Python codegen cleanup review feedback * Regenerate python rpc after rebase Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Replace brittle python codegen symbol test Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
edburns
pushed a commit
that referenced
this pull request
Aug 5, 2026
* Fix Python codegen synthetic permission approval names * Address Python codegen cleanup review feedback * Regenerate python rpc after rebase Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Replace brittle python codegen symbol test Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Python codegen emitting an unintended quicktype-synthesized permission approval class name,
PermissionDecisionApproveForIonApproval, caused by structural merging of similar permission approval schemas.The generator now removes unreferenced synthetic dataclasses after union post-processing, preserving the intended schema-named union aliases such as
PermissionDecisionApproveForSessionApprovalandPermissionDecisionApproveForLocationApproval.Fixes #1125.
Changes
python/copilot/generated/rpc.pyTests
npm run generate:pythonpython3 -m pytest python/test_codegen_type_names.pyPATH=/Users/gautam/.nvm/versions/node/v22.14.0/bin:$PATH python3 -m pytest python/test_*.pygit diff --check