Skip to content

Fix flaky .NET ask-user E2E tests #2107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SteveSandersonMS merged 2 commits into from
Jul 28, 2026
+2 −6
Merged

Fix flaky .NET ask-user E2E tests #2107

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8eb6cb1
Fix flaky .NET ask-user E2E tests
SteveSandersonMS Jul 28, 2026
a9588ff
Use default ask-user test timeout
SteveSandersonMS Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions dotnet/test/E2E/AskUserE2ETests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,11 @@ public async Task Should_Invoke_User_Input_Handler_When_Model_Uses_Ask_User_Tool
}
});

await session.SendAsync(new MessageOptions
await session.SendAndWaitAsync(new MessageOptions
{
Prompt = "Ask me to choose between 'Option A' and 'Option B' using the ask_user tool. Wait for my response before continuing."
});

await TestHelper.GetFinalAssistantMessageAsync(session);

// Should have received at least one user input request
Assert.NotEmpty(userInputRequests);

Expand All @@ -62,13 +60,11 @@ public async Task Should_Receive_Choices_In_User_Input_Request()
}
});

await session.SendAsync(new MessageOptions
await session.SendAndWaitAsync(new MessageOptions
{
Prompt = "Use the ask_user tool to ask me to pick between exactly two options: 'Red' and 'Blue'. These should be provided as choices. Wait for my answer."
});

await TestHelper.GetFinalAssistantMessageAsync(session);

// Should have received a request
Assert.NotEmpty(userInputRequests);

Expand Down
Loading