Skip to content

Update .NET extension reload E2E contract #2176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dmytrostruk wants to merge 1 commit into from
+6 −5
Closed

Update .NET extension reload E2E contract #2176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions dotnet/test/E2E/RpcExtensionsLoadedE2ETests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ public async Task Multiple_Extensions_Are_Discovered_Independently()
}

[Fact]
public async Task Reload_Preserves_Disabled_State_Across_Calls()
public async Task Reload_Restores_Globally_Enabled_State()
{
var extName = CreateUserExtension(prefix: "persistent-disable");
var extId = $"user:{extName}";
Expand All @@ -339,11 +339,12 @@ public async Task Reload_Preserves_Disabled_State_Across_Calls()
await session.Rpc.Extensions.DisableAsync(extId);
await WaitForExtensionAsync(session, extId, ExtensionStatus.Disabled);

// Reload re-runs discovery and respects the per-session disabled set,
// so the extension stays disabled and is not re-launched.
// Reload re-reads persisted global settings, where the extension remains enabled,
// so the session-local disabled state is cleared and the extension is re-launched.
await session.Rpc.Extensions.ReloadAsync();

var afterReload = await WaitForExtensionAsync(session, extId, ExtensionStatus.Disabled);
Assert.Null(afterReload.Pid);
var afterReload = await WaitForExtensionAsync(session, extId, ExtensionStatus.Running);
Assert.NotNull(afterReload.Pid);
Assert.True(afterReload.Pid > 0);
}
}
Loading