Test extension canvas forwarding - #2185
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b804459e-2917-426f-9f9a-9eb9299cc808
There was a problem hiding this comment.
🟢 Ready to approve
The focused test accurately validates the documented SDK boundary behavior.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Adds focused regression coverage confirming extension sessions forward canvas providers to resumeSessionForExtension.
Changes:
- Creates a canvas provider in the extension test.
- Verifies
joinSessionforwards it unchanged.
File summaries
| File | Description |
|---|---|
nodejs/test/extension.test.ts |
Adds canvas-forwarding regression coverage. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
Cross-SDK Consistency Review ✅This PR is test-only — it adds a single regression test in No production API surface is added or changed. No cross-SDK consistency issues are introduced. Other SDKs do not need corresponding updates.
|
|
Closing because this test only covers the SDK forwarding boundary and would not catch the agent-runtime registration race. The regression coverage and fix belong in copilot-agent-runtime. |
A canvas registration regression in Copilot CLI 1.0.76-5 initially appeared to originate in the SDK extension path. The investigation confirmed that
joinSession({ canvases })forwards canvas providers correctly; the actual failure is an agent-runtime connection identity race.This adds focused coverage for the SDK boundary so future regressions cannot silently drop canvases before
resumeSessionForExtension.This PR is test-only and does not fix the runtime issue. The production fix belongs in
copilot-agent-runtime, where extension identity must be published before the first JSON-RPC request is dispatched. Runtime PR github/copilot-agent-runtime#13958 implements that ordering.