Skip to content

Test extension canvas forwarding - #2185

Closed
jmoseley wants to merge 1 commit into
mainfrom
jmoseley-fix-canvas-registration
Closed

Test extension canvas forwarding#2185
jmoseley wants to merge 1 commit into
mainfrom
jmoseley-fix-canvas-registration

Conversation

@jmoseley

Copy link
Copy Markdown
Contributor

A canvas registration regression in Copilot CLI 1.0.76-5 initially appeared to originate in the SDK extension path. The investigation confirmed that joinSession({ canvases }) forwards canvas providers correctly; the actual failure is an agent-runtime connection identity race.

This adds focused coverage for the SDK boundary so future regressions cannot silently drop canvases before resumeSessionForExtension.

This PR is test-only and does not fix the runtime issue. The production fix belongs in copilot-agent-runtime, where extension identity must be published before the first JSON-RPC request is dispatched. Runtime PR github/copilot-agent-runtime#13958 implements that ordering.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: b804459e-2917-426f-9f9a-9eb9299cc808
Copilot AI review requested due to automatic review settings July 31, 2026 17:38
@jmoseley
jmoseley requested a review from a team as a code owner July 31, 2026 17:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Ready to approve

The focused test accurately validates the documented SDK boundary behavior.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Pull request overview

Adds focused regression coverage confirming extension sessions forward canvas providers to resumeSessionForExtension.

Changes:

  • Creates a canvas provider in the extension test.
  • Verifies joinSession forwards it unchanged.
File summaries
File Description
nodejs/test/extension.test.ts Adds canvas-forwarding regression coverage.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Balanced

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

@github-actions

Copy link
Copy Markdown
Contributor

Cross-SDK Consistency Review ✅

This PR is test-only — it adds a single regression test in nodejs/test/extension.test.ts to confirm that joinSession({ canvases }) correctly forwards canvas providers to resumeSessionForExtension.

No production API surface is added or changed. No cross-SDK consistency issues are introduced. Other SDKs do not need corresponding updates.

Generated by SDK Consistency Review Agent for #2185 · sonnet46 15.4 AIC · ⌖ 5.37 AIC · ⊞ 6.6K ·

@jmoseley

Copy link
Copy Markdown
Contributor Author

Closing because this test only covers the SDK forwarding boundary and would not catch the agent-runtime registration race. The regression coverage and fix belong in copilot-agent-runtime.

@jmoseley jmoseley closed this Jul 31, 2026
@stephentoub
stephentoub deleted the jmoseley-fix-canvas-registration branch August 7, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants