Test CI behavior - #2229
Closed
SteveSandersonMS wants to merge 13 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a temporary fixture to validate CI behavior.
Changes:
- Adds a one-line validation fixture.
Show a summary per file
| File | Description |
|---|---|
ci-validation.txt |
Provides temporary content for CI validation. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Review details
Suppressed comments (5)
.github/workflows/ci.yml:26
- This and the other language jobs only print success, so they report green without checking out, building, linting, or testing any SDK. The PR also deletes every reusable SDK test workflow and the required-check orchestrator, which removes CI coverage for Python, Go, .NET, Java, and Rust; restore the real workflows and invoke them here instead of using echo-only placeholders.
python-required:
name: Python required
runs-on: ubuntu-latest
steps:
.github/workflows/publish.yml:1
- Deleting this workflow removes the only package/release pipeline for the Node.js, .NET, Python, Rust, and Java SDKs, including artifact publication and GitHub release creation. A temporary CI test should not disable production releases; restore this workflow before merging.
.github/workflows/copilot-setup-steps.yml:1 - Removing this special workflow means Copilot cloud agent will no longer run the repository's deterministic toolchain and dependency setup from the default branch. Future agent tasks will lose the configured Node.js, Python, Go, .NET, Java, gh-aw, and dependency preparation; preserve this file unless intentionally decommissioning that environment.
.github/workflows/codeql.yml:1 - Deleting this file disables scheduled and pull-request CodeQL analysis for every supported language and GitHub Actions. The replacement workflow performs no security analysis, so restore this workflow before merging.
.github/workflows/ci.yml:4 - The replacement workflow runs only for
pull_request, while the deleted required-check workflow also handledmerge_groupand the language workflows ran on pushes tomain. As a result, merge-queue commits and post-merge main commits receive no SDK validation; restore those triggers together with the real validation jobs.
on:
pull_request:
- Files reviewed: 37/48 changed files
- Comments generated: 1
- Review effort level: Balanced
Contributor
There was a problem hiding this comment.
Review details
Suppressed comments (4)
.github/workflows/ci.yml:15
- This command guarantees that
Node.js requiredfails on every pull request; the lateralways()steps cannot change the job conclusion. It also adds a three-minute delay before reporting the unavoidable failure. Replace this fixture with real validation before the PR is mergeable.
run: exit 0
.github/workflows/publish.yml:1
- Deleting this workflow removes the repository's unified release path for Node.js, .NET, Python, Rust, and Java. For example,
rust/RELEASING.md:3-11explicitly states thatpublish.ymlis the only Rust release workflow, so Rust—and the other package jobs defined here—can no longer be published. Restore the release workflow unless a documented replacement is included.
.github/workflows/codeql.yml:1 - Removing the only CodeQL workflow disables scheduled, push, and pull-request code scanning for every supported language and GitHub Actions. The placeholder
ci.ymldoes not provide an equivalent security scan, so this deletion creates a concrete security coverage regression. Restore CodeQL or add an equivalent scanning workflow.
.github/workflows/copilot-setup-steps.yml:1 - Deleting this specially named workflow disables the repository's customized Copilot cloud-agent environment. The agent will no longer deterministically receive the SDK toolchains, dependencies, gh-aw CLI, or configured pre-commit hooks;
.github/copilot-instructions.md:60also relies on this setup. Restore the setup workflow unless those prerequisites are provided by a replacement.
- Files reviewed: 37/48 changed files
- Comments generated: 1
- Review effort level: Balanced
SteveSandersonMS
changed the base branch from
main
to
test/ci-base-202608031248
August 3, 2026 11:48
Contributor
There was a problem hiding this comment.
Review details
Suppressed comments (6)
.github/workflows/ci.yml:14
- This job reuses the protected
Node.js requiredstatus name but never checks out the repository or runs Node.js validation; the other five required jobs are also unconditional echoes. Because this PR deletes the real required-check orchestrator and per-language test workflows, branch protection can report success for completely untested changes. Restore the real workflow orchestration before merging this CI fixture.
node-required:
name: Node.js required
runs-on: ubuntu-latest
steps:
- name: Initial validation
.github/workflows/publish.yml:1
- Deleting this workflow removes the repository's unified release path for Node.js, .NET, Python, Rust, and Java. In particular,
rust/RELEASING.md:3-11states thatpublish.ymlis the only Rust release workflow, so no Rust release can be produced after this change. Restore the publishing workflows before merge.
.github/workflows/codeql.yml:1 - Removing the CodeQL workflow disables scheduled, push, and pull-request security analysis for every supported language and GitHub Actions. The replacement
ci.ymlperforms no security scanning, so vulnerabilities will no longer be reported through this repository's established scanning gate. Restore this workflow or an equivalent CodeQL configuration.
.github/workflows/copilot-setup-steps.yml:1 - Deleting the Copilot setup workflow removes the deterministic toolchain and dependency setup used by cloud-agent tasks;
.github/copilot-instructions.md:56-60explicitly relies on it to enable the Java pre-commit hooks. Cloud-agent runs will fall back to ad hoc setup and may be unable to build or validate this multi-language repository. Keep this file on the default branch.
.github/workflows/codegen-check.yml:1 - Removing this check means generated protocol types can drift from their schemas without any pull-request or main-branch validation. The new
ci.ymldoes not run code generation or compare the working tree, so stale generated files and Java protocol-version mismatches can now merge unnoticed. Restore the codegen validation workflow.
.github/workflows/block-remove-before-merge.yml:1 - This deletion removes the merge-time guard that rejects
*-remove-before-mergepaths, and the replacement workflow has no equivalent path inspection. Temporary artifacts under those explicitly prohibited directories can therefore be merged intomain. Restore this guard before merging.
- Files reviewed: 37/48 changed files
- Comments generated: 0 new
- Review effort level: Balanced
Keep PR version of ci-validation.txt (test validation state). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
SteveSandersonMS
changed the base branch from
test/ci-base-202608031248
to
main
August 3, 2026 11:51
Contributor
Author
|
Please confirm the temporary fixture remains isolated. |
Contributor
Author
|
Please verify the latest temporary revision. |
Contributor
Author
|
false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary test PR.