Skip to content

Test CI behavior - #2229

Closed
SteveSandersonMS wants to merge 13 commits into
mainfrom
test/ci-validation-20260803113053
Closed

Test CI behavior#2229
SteveSandersonMS wants to merge 13 commits into
mainfrom
test/ci-validation-20260803113053

Conversation

@SteveSandersonMS

Copy link
Copy Markdown
Contributor

Temporary test PR.

Copilot AI review requested due to automatic review settings August 3, 2026 11:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a temporary fixture to validate CI behavior.

Changes:

  • Adds a one-line validation fixture.
Show a summary per file
File Description
ci-validation.txt Provides temporary content for CI validation.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Balanced

Copilot AI review requested due to automatic review settings August 3, 2026 11:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

Copilot AI review requested due to automatic review settings August 3, 2026 11:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread nodejs/test/ci-validation.test.ts Outdated
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings August 3, 2026 11:37
@github-actions github-actions Bot mentioned this pull request Aug 3, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 2/2 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

Copilot AI review requested due to automatic review settings August 3, 2026 11:39
SteveSandersonMS and others added 2 commits August 3, 2026 12:40
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Suppressed comments (5)

.github/workflows/ci.yml:26

  • This and the other language jobs only print success, so they report green without checking out, building, linting, or testing any SDK. The PR also deletes every reusable SDK test workflow and the required-check orchestrator, which removes CI coverage for Python, Go, .NET, Java, and Rust; restore the real workflows and invoke them here instead of using echo-only placeholders.

  python-required:
    name: Python required
    runs-on: ubuntu-latest
    steps:

.github/workflows/publish.yml:1

  • Deleting this workflow removes the only package/release pipeline for the Node.js, .NET, Python, Rust, and Java SDKs, including artifact publication and GitHub release creation. A temporary CI test should not disable production releases; restore this workflow before merging.
    .github/workflows/copilot-setup-steps.yml:1
  • Removing this special workflow means Copilot cloud agent will no longer run the repository's deterministic toolchain and dependency setup from the default branch. Future agent tasks will lose the configured Node.js, Python, Go, .NET, Java, gh-aw, and dependency preparation; preserve this file unless intentionally decommissioning that environment.
    .github/workflows/codeql.yml:1
  • Deleting this file disables scheduled and pull-request CodeQL analysis for every supported language and GitHub Actions. The replacement workflow performs no security analysis, so restore this workflow before merging.
    .github/workflows/ci.yml:4
  • The replacement workflow runs only for pull_request, while the deleted required-check workflow also handled merge_group and the language workflows ran on pushes to main. As a result, merge-queue commits and post-merge main commits receive no SDK validation; restore those triggers together with the real validation jobs.
on:
  pull_request:
  • Files reviewed: 37/48 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread .github/workflows/ci.yml Outdated
Copilot AI review requested due to automatic review settings August 3, 2026 11:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Suppressed comments (4)

.github/workflows/ci.yml:15

  • This command guarantees that Node.js required fails on every pull request; the later always() steps cannot change the job conclusion. It also adds a three-minute delay before reporting the unavoidable failure. Replace this fixture with real validation before the PR is mergeable.
        run: exit 0

.github/workflows/publish.yml:1

  • Deleting this workflow removes the repository's unified release path for Node.js, .NET, Python, Rust, and Java. For example, rust/RELEASING.md:3-11 explicitly states that publish.yml is the only Rust release workflow, so Rust—and the other package jobs defined here—can no longer be published. Restore the release workflow unless a documented replacement is included.
    .github/workflows/codeql.yml:1
  • Removing the only CodeQL workflow disables scheduled, push, and pull-request code scanning for every supported language and GitHub Actions. The placeholder ci.yml does not provide an equivalent security scan, so this deletion creates a concrete security coverage regression. Restore CodeQL or add an equivalent scanning workflow.
    .github/workflows/copilot-setup-steps.yml:1
  • Deleting this specially named workflow disables the repository's customized Copilot cloud-agent environment. The agent will no longer deterministically receive the SDK toolchains, dependencies, gh-aw CLI, or configured pre-commit hooks; .github/copilot-instructions.md:60 also relies on this setup. Restore the setup workflow unless those prerequisites are provided by a replacement.
  • Files reviewed: 37/48 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread .github/workflows/ci.yml
Copilot AI review requested due to automatic review settings August 3, 2026 11:45
@SteveSandersonMS
SteveSandersonMS changed the base branch from main to test/ci-base-202608031248 August 3, 2026 11:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Suppressed comments (6)

.github/workflows/ci.yml:14

  • This job reuses the protected Node.js required status name but never checks out the repository or runs Node.js validation; the other five required jobs are also unconditional echoes. Because this PR deletes the real required-check orchestrator and per-language test workflows, branch protection can report success for completely untested changes. Restore the real workflow orchestration before merging this CI fixture.
  node-required:
    name: Node.js required
    runs-on: ubuntu-latest
    steps:
      - name: Initial validation

.github/workflows/publish.yml:1

  • Deleting this workflow removes the repository's unified release path for Node.js, .NET, Python, Rust, and Java. In particular, rust/RELEASING.md:3-11 states that publish.yml is the only Rust release workflow, so no Rust release can be produced after this change. Restore the publishing workflows before merge.
    .github/workflows/codeql.yml:1
  • Removing the CodeQL workflow disables scheduled, push, and pull-request security analysis for every supported language and GitHub Actions. The replacement ci.yml performs no security scanning, so vulnerabilities will no longer be reported through this repository's established scanning gate. Restore this workflow or an equivalent CodeQL configuration.
    .github/workflows/copilot-setup-steps.yml:1
  • Deleting the Copilot setup workflow removes the deterministic toolchain and dependency setup used by cloud-agent tasks; .github/copilot-instructions.md:56-60 explicitly relies on it to enable the Java pre-commit hooks. Cloud-agent runs will fall back to ad hoc setup and may be unable to build or validate this multi-language repository. Keep this file on the default branch.
    .github/workflows/codegen-check.yml:1
  • Removing this check means generated protocol types can drift from their schemas without any pull-request or main-branch validation. The new ci.yml does not run code generation or compare the working tree, so stale generated files and Java protocol-version mismatches can now merge unnoticed. Restore the codegen validation workflow.
    .github/workflows/block-remove-before-merge.yml:1
  • This deletion removes the merge-time guard that rejects *-remove-before-merge paths, and the replacement workflow has no equivalent path inspection. Temporary artifacts under those explicitly prohibited directories can therefore be merged into main. Restore this guard before merging.
  • Files reviewed: 37/48 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

Copilot and others added 2 commits August 3, 2026 11:49
Keep PR version of ci-validation.txt (test validation state).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@SteveSandersonMS
SteveSandersonMS changed the base branch from test/ci-base-202608031248 to main August 3, 2026 11:51
Copilot AI review requested due to automatic review settings August 3, 2026 11:51
@SteveSandersonMS

Copy link
Copy Markdown
Contributor Author

Please confirm the temporary fixture remains isolated.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 37/48 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread .github/workflows/ci.yml Outdated
Copilot AI review requested due to automatic review settings August 3, 2026 11:54
@SteveSandersonMS

Copy link
Copy Markdown
Contributor Author

Please verify the latest temporary revision.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 37/48 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@SteveSandersonMS

Copy link
Copy Markdown
Contributor Author

false

@SteveSandersonMS
SteveSandersonMS deleted the test/ci-validation-20260803113053 branch August 3, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants