Paginate project item lookup across memberships#2914
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1a67631b-dc18-448a-8be5-81110bfd543a
Contributor
There was a problem hiding this comment.
Pull request overview
Adds pagination when resolving an issue’s Project item membership.
Changes:
- Follows
endCursorthrough all membership pages. - Adds success and not-found pagination tests.
Show a summary per file
| File | Description |
|---|---|
pkg/github/projects_resolver.go |
Implements paginated project-item lookup. |
pkg/github/projects_resolver_test.go |
Tests multi-page resolution and exhaustion. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Medium
zwick
added a commit
that referenced
this pull request
Jul 20, 2026
…utations Rewrite update_project_items to resolve the project, every distinct field, and every item once up front, then write via chunked, aliased updateProjectV2ItemFieldValue / clearProjectV2ItemFieldValue GraphQL mutations built at runtime with reflect.StructOf, instead of one REST PATCH per item. - Extend ResolvedField/projectFieldsCache with GraphQL node IDs and numeric-ID lookup, alongside existing name-based lookup. - Add node_id as a third item-reference form (alongside item_id and item_owner/item_repo/issue_number), bypassing REST lookup entirely. - Deduplicate numeric item_id lookups with bounded-concurrency REST GETs; extend the #2914 paginated issue resolver to also return the item's node ID. - Convert updated_field.value to the correct ProjectV2FieldValue member for TEXT, NUMBER, DATE, SINGLE_SELECT, and ITERATION; route null values to the clear mutation instead of an empty update. - Reject duplicate item+field targets before any writes. - Isolate the reflection mechanics in projects_batch_mutation.go: a cached-by-(kind,size) reflected struct type with positional aliases (item0..itemN-1) and positional input variables (, , ...), matching the first-input workaround required by the pinned githubv4.Client.Mutate signature. - Execute updates then clears in sequential chunks of 20 (provisional, documented headroom rationale), tracking tri-state per-item results (succeeded/failed/unknown); abort remaining chunks after an ambiguous transport-level failure or context cancellation without retrying. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d7dc302d-e6f2-41e9-a2c8-ed598de47067
13 tasks
zwick
added a commit
that referenced
this pull request
Jul 20, 2026
Extend ResolvedField with the GraphQL node ID alongside the existing numeric databaseId, and extend the #2914 paginated issue-item resolver to also return the item's node ID (resolveProjectItemByIssueNumber), keeping resolveProjectItemIDByIssueNumber as a numeric-only wrapper for existing callers. These node IDs are what the upcoming aliased GraphQL mutations need as ItemID/FieldID inputs, in place of the numeric IDs the REST API takes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d7dc302d-e6f2-41e9-a2c8-ed598de47067
RossTarrant
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Paginate issue project-item memberships when resolving an issue to a Project item.
Why
Resolves github/planning-tracking#3696
What changed
pageInfo.endCursoruntil the target Project is found or all memberships are exhausted.includeArchived: true; Add update_project_items batch/bulk field-value writes via aliased GraphQL mutations #2903 requires no test adjustment.MCP impact
The existing
projects_writeissue-reference path now resolves memberships beyond the first 50.Prompts tested (tool changes only)
Security / limits
Pagination remains bounded to 50 memberships per request and stops as soon as the target is found.
Tool renaming
deprecated_tool_aliases.goNote: if you're renaming tools, you must add the tool aliases. For more information on how to do so, please refer to the official docs.
Lint & tests
./script/lint./script/testDocs