Skip to content

Seeing unless !thing breaks my brain #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
issyl0 merged 1 commit into from
Apr 24, 2025
Merged

Seeing unless !thing breaks my brain #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions STYLEGUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
This is GitHub's Ruby Style Guide, inspired by [RuboCop's guide][rubocop-guide].

## Table of Contents

1. [Layout](#layout)
1. [Indentation](#indentation)
2. [Inline](#inline)
Expand Down Expand Up @@ -763,6 +764,22 @@ if x > 10
end
```

* Don't use `unless` with a negated condition.
<a name="no-unless-negation"></a><sup>[[link](#no-unless-negation)]</sup>
* <a href="https://docs.rubocop.org/rubocop/cops_style.html#stylenegatedunless">RuboCop rule: Style/NegatedUnless</a>

```ruby
# bad
unless !condition?
do_something
end

# good
if condition?
do_something
end
```

### Ternary operator

* Avoid the ternary operator (`?:`) except in cases where all expressions are extremely
Expand Down
2 changes: 1 addition & 1 deletion config/default.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1370,7 +1370,7 @@ Style/NegatedIfElseCondition:
Enabled: false

Style/NegatedUnless:
Enabled: false
Enabled: true

Style/NegatedWhile:
Enabled: false
Expand Down
Loading