Skip to content

Fixes clangd warnings #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gr5 merged 3 commits into from
Jan 19, 2026
Merged

Fixes clangd warnings #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
398ff76
Fixes clangd errors
gr5 Jan 18, 2026
7e9d407
Changed colors to m_temp_colors
gr5 Jan 18, 2026
5ad7fb8
removed comment that is no longer relevant
gr5 Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions foucaultview.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ foucaultView::foucaultView(QWidget *parent, SurfaceManager *sm) :
// Using name() and string check for robust color persistence
m_gridColor = QColor(set.value("ronchiGrid/color", "#00FFFF").toString()); // Default Cyan
m_textColor = QColor(set.value("ronchiGrid/textColor", "#FFFFFF").toString()); // Default White

}


Expand Down Expand Up @@ -118,19 +119,18 @@ void foucaultView::showGrid() {
QCheckBox *textToggle = new QCheckBox("Show unit labels", &dlg);
textToggle->setChecked(m_showUnitLabels);

// Color storage (using local temps for the dialog session)
struct State { QColor grid; QColor text; } colors = { m_gridColor, m_textColor };

QPushButton *btnGridCol = new QPushButton("Grid Color");
QPushButton *btnTextCol = new QPushButton("Text Color");

connect(btnGridCol, &QPushButton::clicked, [&]() {
QColor c = QColorDialog::getColor(colors.grid, this);
if (c.isValid()) colors.grid = c;
m_temp_colors = { m_gridColor, m_textColor }; // store current values

connect(btnGridCol, &QPushButton::clicked, this,[this]() {
QColor c = QColorDialog::getColor(m_temp_colors.grid, this);
if (c.isValid()) m_temp_colors.grid = c;
});
connect(btnTextCol, &QPushButton::clicked, [&]() {
QColor c = QColorDialog::getColor(colors.text, this);
if (c.isValid()) colors.text = c;
connect(btnTextCol, &QPushButton::clicked, this, [this]() {
QColor c = QColorDialog::getColor(m_temp_colors.text, this);
if (c.isValid()) m_temp_colors.text = c;
});

form.addRow("Grid Units:", unitCombo);
Expand All @@ -146,13 +146,13 @@ void foucaultView::showGrid() {
form.addRow(&buttonBox);

// Reset Logic
connect(resetBtn, &QPushButton::clicked, [&]() {
connect(resetBtn, &QPushButton::clicked, this, [=]() {
unitCombo->setCurrentIndex(0); // None
spacingSpin->setValue(10.0);
widthSpin->setValue(1);
textToggle->setChecked(true);
colors.grid = Qt::cyan;
colors.text = Qt::white;
m_temp_colors.grid = Qt::cyan;
m_temp_colors.text = Qt::white;
});

connect(&buttonBox, &QDialogButtonBox::accepted, &dlg, &QDialog::accept);
Expand All @@ -163,8 +163,8 @@ void foucaultView::showGrid() {
m_gridSpacing = spacingSpin->value();
m_gridLineWidth = widthSpin->value();
m_showUnitLabels = textToggle->isChecked();
m_gridColor = colors.grid;
m_textColor = colors.text;
m_gridColor = m_temp_colors.grid;
m_textColor = m_temp_colors.text;

// Save to QSettings with "ronchiGrid" prefix
QSettings set;
Expand Down
2 changes: 2 additions & 0 deletions foucaultview.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,8 @@ private slots:
bool m_showUnitLabels = true;
QColor m_gridColor = Qt::cyan;
QColor m_textColor = Qt::white;
struct State { QColor grid; QColor text; } m_temp_colors;


void drawGridOverlay(QImage &img);
explicit foucaultView(QWidget *parent = 0, SurfaceManager *sm = 0);
Expand Down
Loading