clangd to master - I messed up... #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug appeared in v7.4.0
When creating a wavefront based on the average profile, it adds "_avg" to the wavefront name
Fixes issue #328 which was a bug in the subtract wavefront feature.
added blink compare to ronchi compare
added circular grid to ronchi and foucault images
githubdoe
approved these changes
Jan 19, 2026
|
🚀 New build available for commit |
Collaborator
Author
|
Okay great. All PRs are merged. @githubdoe, let me know if you want me to do a new release soon. There are some key fixes in master right now related to the subtract feature. I don't know how important those are to be released soon but if you want this or the other recent stuff then I'll create a PR for the next revisionHistory. Please do a git pull on master and averageProfile branch (if you intend to use that branch). And also please merge master into averageProfile |
Collaborator
Author
|
Ugg. I screwed up again!! I merged master into average profile somehow. Which is fine. But I want to merge averageProfile into mastter. I'll create another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I merged in wrong order. I though I merged clangd into averageProfile first but by accident I merged averageProfile into master first. So now I need to merge averageProfile into master again to get the clangd warning fixes. Please approve dale.