Skip to content

Fixes stale and platform-broken E2E tests for the Graph and rebase editor#5499

Merged
sergeibbb merged 1 commit into
mainfrom
bug/e2e-main-failures
Jul 14, 2026
Merged

Fixes stale and platform-broken E2E tests for the Graph and rebase editor#5499
sergeibbb merged 1 commit into
mainfrom
bug/e2e-main-failures

Conversation

@sergeibbb

@sergeibbb sergeibbb commented Jul 14, 2026

Copy link
Copy Markdown
Member

Fixes the 6 E2E test failures currently on main (the E2E CI job is workflow_dispatch-only, so these accumulated unnoticed). Full suite locally goes from 176 → 197 passing; the "did not run" tail (tests hidden behind serial aborts) collapses from 20 to 3. None of the six was a product bug — all fixes are test-side; no product code is touched.

Root causes & fixes

Test Root cause Fix
graphHeader Launchpad indicator Stale after 5292a3c changed the indicator's <button> to an <a href> (click opens Launchpad) Tag-agnostic .action-button[aria-label^="Launchpad"] locator
graphDetails compare mode (+7 blocked tests) Test hardcoded Control for multi-select; the graph grid requires Cmd on macOS ControlOrMeta modifier
graphReview branch-row actions Stale after df74721 (#5459) replaced the create-branch chip with the Show Branch Actions kebab Assert the kebab chip in the branch row
rebase keyboard shortcuts Same Ctrl-vs-Cmd modifier artifact (app logic verified correct via live repro) ControlOrMeta in all 4 multi-select clicks
graphPin (+2 blocked tests) Pin pipeline verified healthy end-to-end (host ships +pinned rows; webview state holds them) — but in the short e2e panel, WIP auto-selection + the auto-opened bottom details panel (#5402) squeeze the row grid to ~52px, so the virtualizer paints no branch pills and the DOM poll can never match New ensureDetailsPanelClosed() helper before the DOM assertion — the grid gets height, pills render, the meaningful row-context assertion stays
graphHeaderGitActions fetch gear Genuine intermittent flake — passes/fails in isolation runs alike Not fixed here; needs its own investigation

Remaining known issues (documented, out of scope)

  • graphHeaderGitActions.test.ts:203 — intermittent flake (see above)
  • rebase.test.ts:509 (squash/fixup execute) — order-dependent flake: passes in isolation, can time out under in-file serial execution; previously always hidden in the "did not run" tail
  • mcp.test.ts / mcpGitlensTools.test.ts — fail when the machine's gk CLI doesn't expose gitlens_commit_composer (discovery returns only gitlens_launchpad/start_review/start_work); environment/CLI-version dependent, not repo code
  • The CI E2E Tests job has been if: workflow_dispatch since the workflow was introduced (8426e95, Jan 2026) — E2E has never run automatically. With the suite near-green, enabling it on PRs or nightly is worth discussing; the flakes + MCP version-sensitivity above are the remaining blockers.

Verification

  • Each fixed spec verified green in isolation; full suite run: 197 passed / 3 failed (the 3 documented above) / 2 skipped / 3 did not run
  • The 6 original failures were first reproduced identically on bare origin/main (clean-worktree baseline) to rule out interference from other branches
  • pnpm run check passes

Part of this: #5447 (#5391)

@sergeibbb sergeibbb force-pushed the bug/e2e-main-failures branch from 4cb09e5 to eb9f992 Compare July 14, 2026 12:21
@sergeibbb sergeibbb marked this pull request as ready for review July 14, 2026 12:29
@sergeibbb sergeibbb requested a review from a team July 14, 2026 12:29
…itor

- Updates the Launchpad indicator locator for the button-to-anchor
change
- Updates the branch-row assertion for the create-branch chip moving
into
  the Show Branch Actions context menu
- Replaces hardcoded Control multi-select modifiers with ControlOrMeta
so
  multi-select clicks work on macOS (Cmd) as well as Windows/Linux
(Ctrl)
- Collapses the auto-opened details panel in the pin tests so the row
grid
  has enough height to actually render the branch ref pills being
asserted

All 6 previously-failing tests (plus 21 blocked behind their serial
aborts)
now pass; full suite goes from 176 to 197 passing locally.

(#5499, #5447, #5391)
@sergeibbb sergeibbb force-pushed the bug/e2e-main-failures branch from eb9f992 to 27eae4f Compare July 14, 2026 12:31
@augmentcode

augmentcode Bot commented Jul 14, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: Updates Playwright E2E specs to eliminate several stale/broken selectors and platform-specific multi-select behavior in the Graph and rebase editor.

Changes:

  • Use a cross-platform multi-select modifier (ControlOrMeta) in Graph Details compare-mode tests and rebase editor tests
  • Refresh the Launchpad indicator locator to handle the indicator being rendered as an anchor rather than a button
  • Update the Graph review branch-row assertion to the new “Show Branch Actions” kebab chip
  • Close the auto-opened Graph details panel before asserting pinned-row context to ensure virtualized rows actually render in the E2E viewport

Technical Notes: All changes are confined to E2E tests; no product code is modified.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread tests/e2e/specs/graphPin.test.ts
@sergeibbb sergeibbb merged commit 87db512 into main Jul 14, 2026
6 checks passed
@sergeibbb sergeibbb deleted the bug/e2e-main-failures branch July 14, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default the Graph sidebar to unpinned and replace the 'Pro' badge with Start Work

1 participant