Fixes stale and platform-broken E2E tests for the Graph and rebase editor#5499
Merged
Conversation
4cb09e5 to
eb9f992
Compare
…itor - Updates the Launchpad indicator locator for the button-to-anchor change - Updates the branch-row assertion for the create-branch chip moving into the Show Branch Actions context menu - Replaces hardcoded Control multi-select modifiers with ControlOrMeta so multi-select clicks work on macOS (Cmd) as well as Windows/Linux (Ctrl) - Collapses the auto-opened details panel in the pin tests so the row grid has enough height to actually render the branch ref pills being asserted All 6 previously-failing tests (plus 21 blocked behind their serial aborts) now pass; full suite goes from 176 to 197 passing locally. (#5499, #5447, #5391)
eb9f992 to
27eae4f
Compare
🤖 Augment PR SummarySummary: Updates Playwright E2E specs to eliminate several stale/broken selectors and platform-specific multi-select behavior in the Graph and rebase editor. Changes:
Technical Notes: All changes are confined to E2E tests; no product code is modified. 🤖 Was this summary useful? React with 👍 or 👎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the 6 E2E test failures currently on
main(the E2E CI job isworkflow_dispatch-only, so these accumulated unnoticed). Full suite locally goes from 176 → 197 passing; the "did not run" tail (tests hidden behind serial aborts) collapses from 20 to 3. None of the six was a product bug — all fixes are test-side; no product code is touched.Root causes & fixes
graphHeaderLaunchpad indicator<button>to an<a href>(click opens Launchpad).action-button[aria-label^="Launchpad"]locatorgraphDetailscompare mode (+7 blocked tests)Controlfor multi-select; the graph grid requires Cmd on macOSControlOrMetamodifiergraphReviewbranch-row actionsrebasekeyboard shortcutsControlOrMetain all 4 multi-select clicksgraphPin(+2 blocked tests)+pinnedrows; webview state holds them) — but in the short e2e panel, WIP auto-selection + the auto-opened bottom details panel (#5402) squeeze the row grid to ~52px, so the virtualizer paints no branch pills and the DOM poll can never matchensureDetailsPanelClosed()helper before the DOM assertion — the grid gets height, pills render, the meaningful row-context assertion staysgraphHeaderGitActionsfetch gearRemaining known issues (documented, out of scope)
graphHeaderGitActions.test.ts:203— intermittent flake (see above)rebase.test.ts:509(squash/fixup execute) — order-dependent flake: passes in isolation, can time out under in-file serial execution; previously always hidden in the "did not run" tailmcp.test.ts/mcpGitlensTools.test.ts— fail when the machine'sgkCLI doesn't exposegitlens_commit_composer(discovery returns onlygitlens_launchpad/start_review/start_work); environment/CLI-version dependent, not repo codeE2E Testsjob has beenif: workflow_dispatchsince the workflow was introduced (8426e95, Jan 2026) — E2E has never run automatically. With the suite near-green, enabling it on PRs or nightly is worth discussing; the flakes + MCP version-sensitivity above are the remaining blockers.Verification
origin/main(clean-worktree baseline) to rule out interference from other branchespnpm run checkpassesPart of this: #5447 (#5391)