Skip to content

Fixes dropped webview telemetry in GlWebviewApp-based webviews #5502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sergeibbb merged 1 commit into from
Jul 16, 2026
+6 −0
Merged

Fixes dropped webview telemetry in GlWebviewApp-based webviews #5502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/webviews/apps/shared/appBase.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,12 @@ export abstract class GlWebviewApp extends GlElement {
this._ipc,
(this._promos = new PromosContext(this._ipc)),
(this._telemetry = new TelemetryContext(this._ipc)),
// Forward `emitTelemetrySentEvent` DOM events to the host over IPC. Without this bridge
// (present in the legacy `App` base below, but previously missing here) every
// `gl-telemetry-fired` event from a `GlWebviewApp`-based webview was silently dropped.
DOM.on(window, telemetryEventName, e => {
this._telemetry.sendEvent(e.detail);
}),
);

// Focus tracking (sends debounced focus state to host for context keys)
Expand Down
Loading