Fix Windows parent directory ownership using PowerShell Set-Acl#64
Merged
Merged
Conversation
Replace icacls /setowner with PowerShell Set-Acl for setting Windows file and directory ownership. icacls was silently failing on directories because it doesn't explicitly enable SeRestorePrivilege in the process token. PowerShell's Set-Acl uses .NET's SetAccessControl which properly enables the privilege, making it reliable for both files and directories. All paths are batched into a single PowerShell call per user to avoid the performance penalty of spawning multiple processes. Also adds parent directory ownership verification to the E2E config test.
${p} was being interpreted as a JavaScript template literal variable
instead of a PowerShell variable reference, causing the entire batch
ownership command to fail with "ReferenceError: p is not defined".
chris-freeman-glean
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
icacls /setownerwith PowerShellSet-Aclfor setting Windows file/directory ownership —icaclswas silently failing on directories because it doesn't explicitly enableSeRestorePrivilege, while .NET's ACL APIs doTest plan
npm test— all 147 unit tests passnpm run build— builds successfully for all platforms