You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The last commit benefits from low memory fragmentation as each & every new/delete does fragment RAM as well as has extra overhead for computation for new/delete operators...
also we do not need delete/delete[] - those sometimes might be omitted (-> memleak) or in case of exception - hard to delete as well.
when we create objects on stack - we have full guarantee that it'll be freed in any case.
seems this option ReconstructHeaderAsDll is never set (did not find any code for setting it to true)
and second point - according to comments it's doing things vice versa?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the subject
also some other minor cleanups to make compiler happy..
+memory leaks (mainly in dtors)