Fix missing default category for documents added to Tickets via follow-up, task, or solution

[Herafia]

Checklist before requesting a review

Please delete options that are not relevant.

• I have read the CONTRIBUTING document.
• I have performed a self-review of my code.
• I have added tests that prove my fix is effective or that my feature works.
• This change requires a documentation update.

Description

• It fixes !40246
• When a document is added in a Ticket context, the default category must be applied if no other category is selected
• Add tests for Ticket and Change, including the following contexts: ITILFollowup, TicketTask, and ITILSolution

[cedric-anne]

Please rebase to solve conflicts.

[trasher]

Tests are failing

[trasher]

Finally, seems like there is nothing in this PR about the category - or did I miss something?

Please adapt PR title (that will be used as commit message on merge).

[stonebuzz]

The fix for the missing category was added in this pull request:

#21924

However, when a follow-up, task, or solution attaches a document, the default category is not applied, because this case is not handled by the if condition that was corrected in that PR.

[trasher]

OK; I still think the PR title should be enhanced ^^

[stonebuzz]

Ah yes, indeed — he doesn’t mention the document category. I read it too quickly. ^^ @Herafia Can you adapt PR title?

[Herafia]

@stonebuzz, is ok ?!

[stonebuzz]

• When a document is added in a Ticket context, the default category must be applied if no other category is selected
• Add tests for Ticket and Change, including the following contexts: ITILFollowup, TicketTask, and ITILSolution

Maybe

Fix missing default category for documents added to Tickets via follow-up, task, or solution