v6: Ensure Chmod behaviour across BoundOS and ChrootOS#188
Merged
pjbgf merged 5 commits intogo-git:mainfrom Feb 26, 2026
Merged
v6: Ensure Chmod behaviour across BoundOS and ChrootOS#188pjbgf merged 5 commits intogo-git:mainfrom
pjbgf merged 5 commits intogo-git:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR forward-ports fixes from v5 (PR #187) to v6, ensuring consistent Chmod behavior across BoundOS and ChrootOS filesystem implementations, and fixing TempFile to automatically create directories when they don't exist.
Changes:
- Modified BoundOS.TempFile to automatically create the target directory if it doesn't exist, rather than failing
- Added test coverage for the polyfill's Chmod support to verify it properly returns ErrNotSupported when the underlying filesystem doesn't support it
- Updated CI workflows to use "oldstable" and "stable" Go version aliases instead of hardcoded version numbers
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| osfs/os_bound.go | Added directory creation logic in TempFile when directory doesn't exist |
| osfs/os_bound_test.go | Updated TempFile tests to expect success instead of errors when directories don't exist |
| helper/polyfill/polyfill_test.go | Added TestChmod to verify polyfill properly handles Chmod when unsupported |
| .github/workflows/test.yml | Changed go-version from hardcoded values to "oldstable" and "stable" aliases |
| .github/workflows/test_wasip1.yml | Changed go-version from hardcoded values to "oldstable" and "stable" aliases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Previously if the dir didn't already exist an error would be returned, which meant that some go-git features would break when changing ChrootOS with BoundOS. Signed-off-by: Paulo Gomes <pjbgf@linux.com>
This is a follow-up to go-git#171. Signed-off-by: Paulo Gomes <pjbgf@linux.com>
x-ref: go-git/go-git#1769 Signed-off-by: Paulo Gomes <pjbgf@linux.com>
Signed-off-by: Paulo Gomes <pjbgf@linux.com>
pjbgf
force-pushed
the
forward
branch
2 times, most recently
from
1d5f46b to
f76e254
Compare
Signed-off-by: Paulo Gomes <pjbgf@linux.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-port for #187.