Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request restructures the benchmark regression workflow to execute base and PR branch benchmarks in parallel GitHub Actions jobs, reducing total execution time. The benchmark count is increased to 6 (required for benchstat statistical reliability) and file cleanup code is removed from benchmark functions since unique filenames are now used for each iteration and automatic cleanup via b.TempDir() handles directory cleanup.
Changes:
- Restructured GitHub Actions workflow to run base and PR benchmarks in parallel jobs
- Added environment variables for benchmark configuration (count=6, filter for memfs/osfs only)
- Removed per-iteration file cleanup code from
benchCreateandbenchWritefunctions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/bench-regression.yml | Split single sequential benchmark job into three parallel jobs (setup, bench-base, bench-pr) plus a compare job; added environment variables for configuration; implemented artifact-based result sharing |
| test/bench_test.go | Removed per-iteration file cleanup from benchCreate and benchWrite benchmark functions to support parallel execution |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
15650c3 to
93cdb4b
Compare
Signed-off-by: Paulo Gomes <pjbgf@linux.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure the benchmarks are executed in parallel, so that they can finish within 30 mins even with count number of
6, which is the minimum for benchstat results.