Skip to content

Improve and unify non-existing git commit user e-mail tooltip #36094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
silverwind wants to merge 6 commits into
base: main
Choose a base branch
from
+10 −8
Draft

Improve and unify non-existing git commit user e-mail tooltip #36094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8a27f2b
Improve and unify anonymous user e-mail display
silverwind Dec 5, 2025
0809e97
add to latest
silverwind Dec 5, 2025
8c78ba8
revert whitespace
silverwind Dec 5, 2025
1ec7498
fix
silverwind Dec 5, 2025
d714d2e
restart ci
silverwind Dec 5, 2025
b14c757
lint
silverwind Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions templates/repo/commit_page.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,19 +128,21 @@
</div>

<div class="ui bottom attached segment flex-text-block tw-flex-wrap">
<div class="flex-text-inline">
{{if .Author}}
{{if .Author}}
<div class="flex-text-inline">
{{ctx.AvatarUtils.Avatar .Author 20}}
{{if .Author.FullName}}
<a href="{{.Author.HomeLink}}"><strong>{{.Author.FullName}}</strong></a>
{{else}}
<a href="{{.Author.HomeLink}}"><strong>{{.Commit.Author.Name}}</strong></a>
{{end}}
{{else}}
</div>
{{else}}
<div class="flex-text-inline" data-tooltip-content={{.Commit.Author.Email}}>
{{ctx.AvatarUtils.AvatarByEmail .Commit.Author.Email .Commit.Author.Email 20}}
<strong>{{.Commit.Author.Name}}</strong>
{{end}}
</div>
</div>
{{end}}

<span class="text grey">{{DateUtils.TimeSince .Commit.Author.When}}</span>

Expand Down
4 changes: 2 additions & 2 deletions templates/repo/commits_list.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
{{end}}
{{ctx.AvatarUtils.Avatar .User 28 "tw-mr-2"}}<a class="muted author-wrapper" href="{{.User.HomeLink}}">{{$userName}}</a>
{{else}}
{{ctx.AvatarUtils.AvatarByEmail .Author.Email .Author.Name 28 "tw-mr-2"}}
<span class="author-wrapper">{{$userName}}</span>
{{ctx.AvatarUtils.AvatarByEmail .Author.Email .Author.Email 28 "tw-mr-2"}}
<span class="author-wrapper" data-tooltip-content={{.Author.Email}}>{{$userName}}</span>
{{end}}
</div>
</td>
Expand Down
2 changes: 1 addition & 1 deletion templates/repo/latest_commit.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
{{else}}
{{if .LatestCommit.Author}}
{{ctx.AvatarUtils.AvatarByEmail .LatestCommit.Author.Email .LatestCommit.Author.Name 24}}
<span class="author-wrapper" title="{{.LatestCommit.Author.Name}}"><strong>{{.LatestCommit.Author.Name}}</strong></span>
<span class="author-wrapper" data-tooltip-content={{.LatestCommit.Author.Email}}><strong>{{.LatestCommit.Author.Name}}</strong></span>
{{end}}
{{end}}

Expand Down