Expose access to Ops to avoid stringly typing downstream#172
Expose access to Ops to avoid stringly typing downstream#172silasdavis wants to merge 1 commit intogo-interpreter:masterfrom
Conversation
3532253 to
b84fb2b
Compare
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
==========================================
+ Coverage 69.71% 69.72% +0.01%
==========================================
Files 48 48
Lines 5484 5486 +2
==========================================
+ Hits 3823 3825 +2
Misses 1317 1317
Partials 344 344
Continue to review full report at Codecov.
|
Signed-off-by: Silas Davis <silas@monax.io>
| return op, nil | ||
| } | ||
|
|
||
| func Get(opcode byte) Op { |
There was a problem hiding this comment.
Could you add a doc string for this?
|
Might using https://github.com/golang/tools/blob/master/cmd/stringer/stringer.go |
|
Feel free to integrate stringer for Apologies for the confusion, what I meant was to add a doc comment to |
|
ping? |
Avoid this kind of sadness:
https://github.com/perlin-network/life/blob/master/compiler/ssa.go#L445-L454
with:
Signed-off-by: Silas Davis silas@monax.io