-
Notifications
You must be signed in to change notification settings - Fork 103
Update data structure and logic to handle both Swagger 2 and OpenAPI 3 #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thank you. I’ll take a thorough look at it and at your fork as well. We might have a to discuss a few things. I’ll let you know shortly |
…3 documents Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
|
updated: added a 2nd commit to run spec_test with swagger and openapi files, to confirm both are well supported |
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #234 +/- ##
==========================================
- Coverage 67.51% 63.69% -3.82%
==========================================
Files 30 34 +4
Lines 2395 2749 +354
==========================================
+ Hits 1617 1751 +134
- Misses 615 791 +176
- Partials 163 207 +44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Change type
🆕 Add support for Open API 3.x
Short description
This PR introduce support for Open API 3.x document
Fixes
fixes #21
Full description
Add required attributes so the same codebase can be used to parse swagger 2.x and openapi 3.x documents.
This is used in https://github.com/allons-y/openapi (go-swagger fork) as a proof of concept
Let me know if this makes sense, then I'll adapt tests so they are executed and adapted for both file formats
Checklist