Skip to content

security: redact bot token from GetUpdatesChan error logs #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matvievsky wants to merge 1 commit into
base: master
Choose a base branch
from
Open

security: redact bot token from GetUpdatesChan error logs #792

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion bot.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,11 @@ func (bot *BotAPI) GetUpdatesChan(config UpdateConfig) UpdatesChannel {

updates, err := bot.GetUpdates(config)
if err != nil {
log.Println(err)
// Transport-level errors (e.g. "unexpected EOF") come back as a
// *url.Error whose message embeds the full request URL — and the
// bot token is part of that URL, so logging err verbatim leaks
// it in cleartext. Redact before printing.
log.Println(strings.ReplaceAll(err.Error(), bot.Token, "[REDACTED]"))
log.Println("Failed to get updates, retrying in 3 seconds...")
time.Sleep(time.Second * 3)

Expand Down