Skip to content

packaging: add nix#525

Open
dominic-r wants to merge 14 commits intomainfrom
sdko/nix-pkg
Open

packaging: add nix#525
dominic-r wants to merge 14 commits intomainfrom
sdko/nix-pkg

Conversation

@dominic-r
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Dec 24, 2025

Codecov Report

❌ Patch coverage is 43.26923% with 59 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.70%. Comparing base (7636e57) to head (8982284).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
pkg/agent_system/agent_starter/starter.go 46.55% 26 Missing and 5 partials ⚠️
pkg/agent_system/device/signed.go 47.22% 15 Missing and 4 partials ⚠️
pkg/browser_support/handler.go 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #525      +/-   ##
==========================================
+ Coverage   38.35%   38.70%   +0.34%     
==========================================
  Files         204      204              
  Lines        6945     7017      +72     
==========================================
+ Hits         2664     2716      +52     
- Misses       3948     3962      +14     
- Partials      333      339       +6     
Flag Coverage Δ
go-e2e 42.72% <45.16%> (+0.22%) ⬆️
go-integration 17.80% <39.78%> (+1.99%) ⬆️
go-macos-15 15.98% <39.78%> (+1.95%) ⬆️
go-ubuntu-24.04 15.55% <39.78%> (+2.02%) ⬆️
go-ubuntu-24.04-arm 14.96% <38.46%> (+1.94%) ⬆️
go-windows-2025 15.22% <39.78%> (+1.95%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Dec 24, 2025

🚀 Deployed on https://pr-525--authentik-pkg.netlify.app

@dominic-r dominic-r marked this pull request as draft December 26, 2025 18:19
@dominic-r dominic-r marked this pull request as ready for review December 26, 2025 18:52
@authentik-automation authentik-automation bot temporarily deployed to pkg December 28, 2025 20:10 Inactive
@authentik-automation authentik-automation bot temporarily deployed to pkg December 28, 2025 20:34 Inactive
@dominic-r dominic-r changed the title nix packaging: add nix Dec 28, 2025
@dominic-r dominic-r requested a review from BeryJu December 28, 2025 23:24
@authentik-automation authentik-automation bot temporarily deployed to pkg December 29, 2025 01:08 Inactive
@authentik-automation authentik-automation bot temporarily deployed to pkg December 30, 2025 22:57 Inactive
@codecov
Copy link

codecov bot commented Mar 8, 2026

Bundle Report

Changes will increase total bundle size by 4.31kB (0.1%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
browser-ext-esm 4.42MB 4.31kB (0.1%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: browser-ext-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
background.js 2.11kB 4.08MB 0.05%
content.js 1.89kB 2.79kB 209.56% ⚠️
utils/native.d.ts 20 bytes 859 bytes 2.38%
content/content.d.ts 299 bytes 336 bytes 808.11% ⚠️

Files in background.js:

  • ./src/utils/native.ts → Total Size: 5.68kB

  • ./src/background/background.ts → Total Size: 1.01kB

Files in content.js:

  • ./src/content/content.ts → Total Size: 2.75kB

- ak-sysd only searched /Applications, so nix installs in /Applications/Nix Apps never launched the GUI agent.
- The Darwin module relied on a flaky one-shot open instead of exposing the app at the upstream path.
- The Darwin module seeded only the default config path, ignoring services.authentik.configFile.
- The Darwin module missed the Chromium native-messaging manifest.
- The browser extension native port could disconnect and fail signing requests.
- Browser/native signing errors were swallowed and turned into useless empty responses.
- ak-sysd challenge validation failed despite matching JWKS kid values because the key lookup path was broken.
- Missing tests for macOS app path resolution and direct JWKS challenge validation were added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

1 participant