Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #525 +/- ##
==========================================
+ Coverage 38.35% 38.70% +0.34%
==========================================
Files 204 204
Lines 6945 7017 +72
==========================================
+ Hits 2664 2716 +52
- Misses 3948 3962 +14
- Partials 333 339 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
🚀 Deployed on https://pr-525--authentik-pkg.netlify.app |
abb20b7 to
d77e433
Compare
52f20f9 to
f89bd26
Compare
Bundle ReportChanges will increase total bundle size by 4.31kB (0.1%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: browser-ext-esmAssets Changed:
Files in
Files in
|
- ak-sysd only searched /Applications, so nix installs in /Applications/Nix Apps never launched the GUI agent. - The Darwin module relied on a flaky one-shot open instead of exposing the app at the upstream path. - The Darwin module seeded only the default config path, ignoring services.authentik.configFile. - The Darwin module missed the Chromium native-messaging manifest. - The browser extension native port could disconnect and fail signing requests. - Browser/native signing errors were swallowed and turned into useless empty responses. - ak-sysd challenge validation failed despite matching JWKS kid values because the key lookup path was broken. - Missing tests for macOS app path resolution and direct JWKS challenge validation were added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.