Skip to content

[WIP] [ee/wcp] refs #440: login ui display issue #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
speedbooster wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[WIP] [ee/wcp] refs #440: login ui display issue #710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f37f60
refs: clean cache in make clean
speedbooster Mar 8, 2026
5ad08d9
refs #440: added nullptr check for CefApp
speedbooster Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ all: clean gen
.PHONY: clean
clean:
rm -rf ${PWD}/bin/*
rm -rf ${PWD}/cache/*

.PHONY: gen
gen: go-gen-proto rs-gen-proto ee/psso/gen
Expand Down
17 changes: 12 additions & 5 deletions ee/wcp/ak_cred_provider/Provider.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,12 +124,19 @@ void Provider::SetCefApp(sHookData* pData) {
// Initialize the CEF browser process. May return false if initialization
// fails or if early exit is desired (for example, due to process singleton
// relaunch behavior).
if (!CefInitialize(main_args, settings, m_pCefApp.get(), sandbox_info)) {
spdlog::debug("CefGetExitCode");
// return CefGetExitCode();
m_pCefApp = nullptr;
if (m_pCefApp)
{
if (!CefInitialize(main_args, settings, m_pCefApp.get(), sandbox_info)) {
spdlog::debug("CefGetExitCode");
// return CefGetExitCode();
m_pCefApp = nullptr;
}
spdlog::debug("CefInitialize");
}
else
{
spdlog::debug("SetCefApp: Could not instantiate SimpleApp. CEF app setup failed.");
}
spdlog::debug("CefInitialize");
// Run the CEF message loop. This will block until CefQuitMessageLoop() is
// called.
// CefRunMessageLoop();
Expand Down
Loading