Skip to content

PHP Compat: Set flags for html_entity_decode(). #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agibson-godaddy merged 2 commits into from
Dec 5, 2025
Merged

PHP Compat: Set flags for html_entity_decode(). #795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d53810f
Set flags for html_entity_decode() to PHP 8.1 defaults.
peterwilsoncc Dec 2, 2025
851973a
Tests: Optional params must follow required params.
peterwilsoncc Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/integration/API/CacheableAPIBaseTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ public function provider_get_request_transient_key(): array {
*
* @throws ReflectionException
*/
public function test_is_request_cacheable( bool $is_cacheable, $filter_value = null, bool $expected ) {
public function test_is_request_cacheable( bool $is_cacheable, $filter_value, bool $expected ) {

$api = $this->get_new_api_instance_with_request( $this->get_new_request_instance( $is_cacheable ) );

Expand Down Expand Up @@ -313,7 +313,7 @@ public function provider_is_request_cacheable(): array {
*
* @throws ReflectionException
*/
public function test_get_request_cache_lifetime( int $lifetime, $filter_value = null, int $expected ) {
public function test_get_request_cache_lifetime( int $lifetime, $filter_value, int $expected ) {

$api = $this->get_new_api_instance_with_request( $this->get_new_request_instance()->set_cache_lifetime( $lifetime ) );

Expand Down
2 changes: 1 addition & 1 deletion woocommerce/payment-gateway/admin/class-sv-wc-payment-gateway-admin-order.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ public function ajax_process_capture() {
}

wp_send_json_success( [
'message' => html_entity_decode( wp_strip_all_tags( $result['message'] ) ), // ensure any HTML tags are removed and the currency symbol entity is decoded
'message' => html_entity_decode( wp_strip_all_tags( $result['message'] ), ENT_QUOTES | ENT_SUBSTITUTE | ENT_HTML401 ), // ensure any HTML tags are removed and the currency symbol entity is decoded
] );

} catch ( SV_WC_Payment_Gateway_Exception $e ) {
Expand Down
Loading