Open
Conversation
dsouzae
reviewed
Oct 22, 2019
Comment on lines
-125
to
+123
| return time.Now(), fmt.Errorf("ibgo: '%s' too short to be datetime format '%s'", timeString, format) | ||
| return t, fmt.Errorf("ibgo: '%s' too short to be datetime format '%s'", timeString, format) |
Contributor
There was a problem hiding this comment.
Any reason for this change? As t is never set, so it would be the default value.
Author
There was a problem hiding this comment.
Just trying to make consistent with idiomatic Go. For example, in the case of:
t, err := time.Parse("20060102", "bad date")
The value of t is the default value
dsouzae
reviewed
Oct 22, 2019
Comment on lines
-131
to
+129
| return time.Now(), fmt.Errorf("ibgo: '%s' does not contain expected whitespace for datetime format '%s'", timeString, format) | ||
| return t, fmt.Errorf("ibgo: '%s' does not contain expected whitespace for datetime format '%s'", timeString, format) |
dsouzae
reviewed
Oct 22, 2019
Comment on lines
-141
to
+139
| return time.Now(), fmt.Errorf("ibgo: '%s' wrong length to be datetime format '%s'", timeString, format) | ||
| return t, fmt.Errorf("ibgo: '%s' wrong length to be date format '%s'", timeString, format) |
dsouzae
reviewed
Oct 22, 2019
Comment on lines
-159
to
+157
| return time.Now(), fmt.Errorf("ibgo: unsupported read time format '%v'", f) | ||
| return t, fmt.Errorf("ibgo: unsupported read time format '%v'", f) |
dsouzae
reviewed
Oct 22, 2019
| @@ -156,7 +154,7 @@ func readTime(b *bufio.Reader, f timeFmt) (t time.Time, err error) { | |||
| } | |||
Contributor
There was a problem hiding this comment.
Missing consistent change if returning error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.