Skip to content

fix(ci): added pragma to dagger functions to pass a default directory to the source flag#699

Merged
bupd merged 2 commits intogoharbor:mainfrom
rkcoder101:fix/dagger-source-flag
Mar 3, 2026
Merged

fix(ci): added pragma to dagger functions to pass a default directory to the source flag#699
bupd merged 2 commits intogoharbor:mainfrom
rkcoder101:fix/dagger-source-flag

Conversation

@rkcoder101
Copy link
Contributor

@rkcoder101 rkcoder101 commented Feb 11, 2026

Copilot AI review requested due to automatic review settings February 11, 2026 14:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Dagger pipeline entrypoints so the source *dagger.Directory argument defaults to the repository root (and respects .gitignore), making --source no longer necessary for common dagger call invocations (per #696).

Changes:

  • Added Dagger parameter pragmas // +ignore=[".gitignore"] and // +defaultPath="." to source arguments.
  • Applied the change across the lint, test, vuln-check, docs, and dev-build Dagger functions.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.dagger/vuln.go Adds default source directory + ignore rules to vulnerability check functions.
.dagger/test.go Adds default source directory + ignore rules to test and coverage functions.
.dagger/lint.go Adds default source directory + ignore rules to lint functions.
.dagger/doc.go Adds default source directory + ignore rules to doc generation function.
.dagger/buildDev.go Adds default source directory + ignore rules to the dev build function.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@NucleoFusion NucleoFusion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rkcoder101
Copy link
Contributor Author

@bupd @NucleoFusion can we merge this?

Copy link
Collaborator

@qcserestipy qcserestipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rkcoder101 please fix the merge conflicts with upstream main

…he source flag

Signed-off-by: Rayyan Khan <rayyanrehman101@gmail.com>
@rkcoder101 rkcoder101 force-pushed the fix/dagger-source-flag branch from d2f8ad6 to 58fa0f4 Compare March 3, 2026 13:47
@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 7.23%. Comparing base (60ad0bd) to head (ef14d9c).
⚠️ Report is 104 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##             main    #699      +/-   ##
=========================================
- Coverage   10.99%   7.23%   -3.76%     
=========================================
  Files         173     261      +88     
  Lines        8671   12923    +4252     
=========================================
- Hits          953     935      -18     
- Misses       7612   11880    +4268     
- Partials      106     108       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@bupd bupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bupd bupd merged commit 63c5ea2 into goharbor:main Mar 3, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: Make --source optional in Dagger functions

5 participants