fix: pin golangci-lint version to v2.9.0-alpine#713
fix: pin golangci-lint version to v2.9.0-alpine#713adityashekhawat1999 wants to merge 2 commits intogoharbor:mainfrom
Conversation
Signed-off-by: Aditya Pratap Singh Shekhawat <adityashekhawat@Adityas-MacBook-Air.local>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #713 +/- ##
=========================================
- Coverage 10.99% 7.24% -3.75%
=========================================
Files 173 260 +87
Lines 8671 12913 +4242
=========================================
- Hits 953 935 -18
- Misses 7612 11870 +4258
- Partials 106 108 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Prasanth Baskar <bupdprasanth@gmail.com>
|
I have few considerations to share. First of all, the lint job fails only because of So it arises multiple issues, notably Also it is important to note that the So obviously, with the So it is good to update the |
qcserestipy
left a comment
There was a problem hiding this comment.
I also wanted to add that I reviewed PR #715 and I think it is a good solution to deal with the rule sets instead of pinning the version of golangci-lint. It would keep us from using security fixes or improved functionality in this package if we pin it.
|
closing in favor of #715 |
fixes #711
Overview
The Dagger lint pipeline currently uses
golangci/golangci-lint:latest-alpine.Using the
latesttag can lead to unexpected CI failures when a new version of golangci-lint is released.Changes
Pinned golangci-lint image to
v2.9.0-alpine, which is the previously working version observed in CI logs.Reason
Pinning the version ensures consistent and stable lint behaviour across CI runs and prevents breaking changes introduced by newer releases.
No functional code changes were made.