datastore: clarify GetMulti documentation regarding partial loading behavior#400
Open
adavila0703 wants to merge 1 commit intogolang:masterfrom
Open
datastore: clarify GetMulti documentation regarding partial loading behavior#400adavila0703 wants to merge 1 commit intogolang:masterfrom
adavila0703 wants to merge 1 commit intogolang:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered a bug at Salesloft where we weren't properly handling entities that were successfully loaded when GetMulti returned a MultiError. The current documentation doesn't explicitly state that successful entities are still loaded into the destination slice even when errors occur with other entities.
This PR clarifies the documentation to make this behavior more apparent, which should hopefully help prevent similar issues..