Skip to content

Conversation

@zhabba
Copy link
Contributor

@zhabba zhabba commented Dec 1, 2025

Now using gooddata-http-client:3.0.0 thus
migrated to Apache Http5 Classic API
Http4 kept to be used by Sardine WebDAV client.

Signed-off-by: Dmitrii Puzikov <dmitrii.puzikov@gooddata.com>
@zhabba zhabba requested a review from Copilot December 1, 2025 16:59
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request migrates the codebase to use gooddata-http-client:3.0.0, which involves upgrading from Apache HTTP 4 to Apache HTTP 5 Classic API. The changes are primarily code formatting and style improvements, with the actual HTTP client migration work happening in dependencies.

Key Changes:

  • Removal of trailing blank lines from numerous Java source files
  • Reorganization of import statements to follow standard ordering (external imports, then internal imports, then static imports)
  • Repositioning of methods within classes to improve organization
  • Formatting improvements for code readability

Reviewed changes

Copilot reviewed 293 out of 1032 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Multiple warehouse model files Removed trailing blank lines and reordered imports
Multiple project model files Reordered imports, removed trailing blank lines, and repositioned methods
Multiple notification files Import reorganization and trailing blank line removal
Multiple metadata files Import reorganization, method reordering, and formatting cleanup
Multiple executeafm files Import reorganization, javadoc formatting, and trailing blank line removal
Multiple connector files Method reordering, import cleanup, and trailing blank line removal

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@zhabba zhabba force-pushed the dp-GRIF-316-rework branch from 757d025 to 9a4e04d Compare December 2, 2025 09:23
Copy link

@milandufek milandufek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@zhabba zhabba merged commit 8e95e4d into master Dec 3, 2025
1 check passed
@zhabba zhabba deleted the dp-GRIF-316-rework branch December 3, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants