Fix flaky test under Python 3.12. #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_715951508
branch
from
012aec8 to
fd68dd5
Compare
The functionality to enable networking (i.e. turn off airplane mode and turn on wifi) is done asynchronously within `A11yGrpcWrapper._fetch_task_extras()`. Under some conditions, repeated calls could interfere with each other before the `concurrent.futures.Future` was reset, and this caused one test case to fail. This change makes this 100% robust by moving the reset to the top of the function to avoid having the reset trigger within the same call of `_fetch_task_extras()`. PiperOrigin-RevId: 716214824
copybara-service
bot
force-pushed
the
test_715951508
branch
from
fd68dd5 to
fa2f00c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix flaky test under Python 3.12.
The functionality to enable networking (i.e. turn off airplane mode and turn on
wifi) is done asynchronously within
A11yGrpcWrapper._fetch_task_extras().Under some conditions, repeated calls could interfere with each other before
the
concurrent.futures.Futurewas reset, and this caused one test case tofail.
This change makes this 100% robust by moving the reset to the top of the
function to avoid having the reset trigger within the same call of
_fetch_task_extras().