Skip to content

Adjust some docstrings. #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Dec 1, 2025
Merged

Adjust some docstrings. #294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions android_env/components/adb_controller_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ def test_init_server(self, mock_sleep, mock_check_output):
def test_init_server_with_adb_server_port_from_os_env(
self, mock_sleep, mock_check_output
):
"""Us OS env vars if `use_adb_server_port_from_os_env` is True."""

# Arrange.
# Set the ADB server port to 1234 in the OS environment.
os.environ['ANDROID_ADB_SERVER_PORT'] = '1234'
Expand Down Expand Up @@ -169,7 +171,7 @@ def test_restart_server(self, mock_sleep, mock_check_output):
@mock.patch.object(subprocess, 'check_output', autospec=True)
@mock.patch.object(time, 'sleep', autospec=True)
def test_invalid_command(self, mock_sleep, mock_check_output):
"""When an adb command fails, we expect the server to be restarted."""
"""Restart the server when given an invalid command."""

# Arrange.
restart_sequence = ['fake_output'.encode('utf-8')] * 3
Expand Down Expand Up @@ -238,7 +240,7 @@ def test_invalid_command(self, mock_sleep, mock_check_output):
@mock.patch.object(subprocess, 'check_output', autospec=True)
@mock.patch.object(time, 'sleep', autospec=True)
def test_avoid_infinite_recursion(self, mock_sleep, mock_check_output):
"""When an adb command fails, we expect the server to be restarted."""
"""Raise an error if the command fails even after restarts."""

del mock_sleep
mock_check_output.side_effect = subprocess.CalledProcessError(
Expand Down