Skip to content

Conversation

@hari-silvers
Copy link

@hari-silvers hari-silvers commented Jan 25, 2026

Description

Before:
image

After :
image

  • Modified the Linux-only shell commands (mkdir -p, cp) in wireit copy-spec with Node-based cross-platform commands (mkdirp, cpy-cli).
  • This allows npm run build to succeed on Windows, Git Bash, WSL, and Linux.
  • I have installed two packages(mkdirp, cpy-cli), so there will be changes in the package-lock.json file too and committed those changes too.

Pre-launch Checklist

  • I signed the [CLA].
  • I read the [Contributors Guide].
  • I read the [Style Guide].
  • I have added updates to the [CHANGELOG].
  • I updated/added relevant documentation.
  • My code changes (if any) have tests.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a great improvement for cross-platform compatibility, replacing shell-specific commands with Node.js-based alternatives. The changes are clear and well-described. My review includes a critical point about the required Node.js version introduced by a new dependency, which could impact compatibility. I've also added a suggestion regarding automated testing for these build changes to align with the repository's style guide and ensure long-term stability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

1 participant