Skip to content

Conversation

@jacobsimionato
Copy link
Collaborator

Updates the quickstart guide to use pip install . instead of pip install -r requirements.txt, as the project uses pyproject.toml.

Fixes #424

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the manual installation command in the quickstart guide to use pip install ., which is appropriate for a project configured with pyproject.toml. However, I've identified a significant inconsistency in the surrounding documentation. The guide suggests Python 3.10+ is sufficient, but the project requires Python 3.13+. This will cause the installation to fail for users with an intermediate Python version. I've added a high-severity comment to highlight this issue, which should be addressed to ensure the quickstart works as intended for all users.

# If not, manually install them:
cd ../../agent/adk/restaurant_finder
pip install -r requirements.txt
pip install .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While pip install . is the correct command for this project, it will fail for users with a Python version between 3.10 and 3.12. The project's pyproject.toml requires Python 3.13 or newer (requires-python = ">=3.13"), but a comment in this code block suggests 3.10+ is sufficient. To prevent installation errors, the Python version mentioned in the guide should be updated to 3.13+.

@jacobsimionato jacobsimionato merged commit 7a15db2 into google:main Jan 27, 2026
6 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in A2UI Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Quick start documentation needs to be updated [https://a2ui.org/quickstart/#contact-lookup-demo]

2 participants