Add presubmit test to verify v2 metrics are working when enabled #1980
+131
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjreynol
force-pushed
the
test_metrics
branch
8 times, most recently
from
8224455 to
ce50854
Compare
cjreynol
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
jmacnak
reviewed
Jan 9, 2026
cjreynol
force-pushed
the
test_metrics
branch
from
ce50854 to
183b800
Compare
cjreynol
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
cjreynol
force-pushed
the
test_metrics
branch
from
183b800 to
0394188
Compare
cjreynol
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
jmacnak
approved these changes
Jan 16, 2026
The main reason for the change is to use the presence of the event files as a signal that metrics transmissions are working. That signal will be used in an upcoming presubmit test to verify metrics functionality. This means the files will not be written out for debugging when metrics are disabled. However, that is offset for Googlers who will have the package installed by default and now have metrics enabled even for local development. Since the event files are only written after transmissions, I think there is less likelihood of confusion on whether metrics are being transmitted. This commit also removes the README that tried to explain this to users who stumbled upon the `metrics` directory. Bug: 453757034
To be used in the upcoming metrics transmission presubmit test Bug: 453757034
Enable metrics for our Github presubmit tests by including the package in the container definition used by `presubmit.yaml`. Also add the package to the Kokoro presubmits install list, used for `.kokoro/presubmit.sh`. Bug: 453757034
This test works by using the existence of the metrics event files, which are now written AFTER transmission, as a signal metrics were transmitted successfully. Bug: 453757034
cjreynol
force-pushed
the
test_metrics
branch
from
0394188 to
7272605
Compare
cjreynol
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: 453757034