Use std::string_view more in subprocess.[cpp,h], and other refactoring
#2023
+82
−120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These functions always do an allocation anyway. Also moved the implementation to the source file.
This always does an allocation internally anyway. Also moved the implementation to the source file, removing the abseil include from the header.
This had no callers.
…t case This saves going through an intermediate std::stringstream when it can move a single string argument into the argument vector.
- Remove `cuttlefish::Execute` overloads that take an environment: there are no callers. - Accept a `std::vector<std::string>` by value: string arguments can be moved into the `Command` without reallocation.
3405691582
reviewed
Jan 16, 2026
jemoreira
approved these changes
Jan 16, 2026
This avoids a string allocation per environment variable.
Databean
force-pushed
the
subprocess_string_view
branch
from
b36a9ad to
adf4f18
Compare
3405691582
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to discussion in #2010