If emitLoggingCommands was called directly on a <velog> element with more than 1 child:
#2657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith more than 1 child: * The in-place mutations would succeed (i.e., make `<velog>`'s children its siblings then delete `<velog>`) * All elements of the `newChildren` array then get reparented to a new `DocumentFragment` before returning from `emitLoggingCommands`, effectively deleting them from the new parent. This refactor returns the lone element in `newElements` if len==1, returning a `DocumentFragment` of `newElements` otherwise. PiperOrigin-RevId: 850245530
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
emitLoggingCommandswas called directly on a<velog>element with more than 1 child:<velog>'s children its siblings then delete<velog>)newChildrenarray then get reparented to a newDocumentFragmentbefore returning fromemitLoggingCommands, effectively deleting them from the new parent.This refactor returns the lone element in
newElementsif len==1, returning aDocumentFragmentofnewElementsotherwise.